Autoscale node resize #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this work looks great! I'm just going to wait until the update_scale_settings() method is complete and that PR is merged since it looks like some of that code made it into this PR. It should be easier to merge correctly once the other PR is merged to main |
* new docker upload image * updated docker image upload functions * included missing : * add print statement * bump version
* Added unit tests and documentation updates * Added example autoscaling formula * Accepting pool name as function parameter instead of config parameter * Update documentation * change inputs to helpers.update_pool * update parameters for helpers.Update_pool in clients * Validate parameters being passed * Added unit tests * Add unit tests and moved check_autoscale_parameters params to helpers * bump setup.py version * bump pyproject.toml version * Changed scaling mode to parameter * Update setup.py version * Update pyproject.toml version --------- Co-authored-by: Ryan Raasch <[email protected]>
ryanraaschCDC
approved these changes
Sep 26, 2024
ryanraaschCDC
approved these changes
Sep 26, 2024
xop5
added a commit
that referenced
this pull request
Oct 9, 2024
* Added unit tests and documentation updates * Added example autoscaling formula * Accepting pool name as function parameter instead of config parameter * Update documentation * Autosize resize time reduction * Update setup.py version * Update pyproject.toml version * Upload docker image function (#129) * new docker upload image * updated docker image upload functions * included missing : * add print statement * bump version * Added unit tests and documentation updates (#127) * Added unit tests and documentation updates * Added example autoscaling formula * Accepting pool name as function parameter instead of config parameter * Update documentation * change inputs to helpers.update_pool * update parameters for helpers.Update_pool in clients * Validate parameters being passed * Added unit tests * Add unit tests and moved check_autoscale_parameters params to helpers * bump setup.py version * bump pyproject.toml version * Changed scaling mode to parameter * Update setup.py version * Update pyproject.toml version --------- Co-authored-by: Ryan Raasch <[email protected]> * Removed unnecessary tests --------- Co-authored-by: Ryan Raasch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.