add details about sample target #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hub correctly configured! 2024-10-16 21:35:54 UTC |
dylanhmorris
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Looks very good, thanks @sbidari! A few tweaks/suggestions.
| @@ -169,7 +169,7 @@ Values in the `output_type` column are either | |||
| - "quantile" or | |||
| - "samples". | |||
|
|
|||
| This value indicates whether that row corresponds to a quantile forecast or sample trajectories for weekly incident hospital admissions. | |||
| This value indicates whether that row corresponds to a quantile forecast or sample trajectories for weekly incident hospital admissions. Samples can be submitted either for individual modeling tasks, where each `horizon` and `location` is treated independently, or as a part of a compound modeling task that encodes dependencies across forecast `horizon` and `location`. | |||
There was a problem hiding this comment.
Suggested change
| This value indicates whether that row corresponds to a quantile forecast or sample trajectories for weekly incident hospital admissions. Samples can be submitted either for individual modeling tasks, where each `horizon` and `location` is treated independently, or as a part of a compound modeling task that encodes dependencies across forecast `horizon` and `location`. | |
| This value indicates whether that row corresponds to a quantile forecast or sample trajectories for weekly incident hospital admissions. Samples can be submitted either for individual modeling tasks, where each `horizon` and `location` is treated independently, or as a part of a compound modeling task that encodes predictive statistical dependency across forecast `horizon`s and/or `location`s. |
We want to allow single location / multiple horizon joint samples and single horizon multiple location joint samples.
| "min_samples_per_task": 100, | ||
| "max_samples_per_task": 100 | ||
| "max_samples_per_task": 100, |
There was a problem hiding this comment.
I think we could consider allowing more than this. Main concern would be disk space / file size.
| @@ -217,8 +217,18 @@ Teams must provide the following 23 quantiles: | |||
|
|
|||
| #### sample output | |||
|
|
|||
| When the predictions are samples, values in the `output_type_id` column are indexes for the samples. | |||
| *More details to be added here* | |||
| When the predictions are samples, values in the `output_type_id` column are indexes for the samples. The `output_type_id` is used to indicate the dependence across multiple task id variables when samples come from a joint predictive distribution. For example, samples from a joint predictive distribution across `horizon`, will share `output_type_id` for predictions for different horizons within a same `location` as below: | |||
There was a problem hiding this comment.
Suggested change
| When the predictions are samples, values in the `output_type_id` column are indexes for the samples. The `output_type_id` is used to indicate the dependence across multiple task id variables when samples come from a joint predictive distribution. For example, samples from a joint predictive distribution across `horizon`, will share `output_type_id` for predictions for different horizons within a same `location` as below: | |
| When the predictions are samples, values in the `output_type_id` column are indexes for the samples. The `output_type_id` is used to indicate the dependence across multiple task id variables when samples come from a joint predictive distribution. For example, samples from a joint predictive distribution across `horizon`s for a given `location`, will share `output_type_id` for predictions for different horizons within a same `location` as below: |
| | 2024-10-15 | 0 | MA | sample | s1 | - | | ||
| | 2024-10-15 | 1 | MA | sample | s1 | - | | ||
|
|
||
| Here, `output_type_id = s0` specifies that the predictions for horizons -1, 0, and 1 are part of the same joint distribution. More details on sample output can be found in the [hubverse documentation of sample output type](https://hubverse.io/en/latest/user-guide/sample-output-type.html). |
There was a problem hiding this comment.
For extra clarity, give an example of a second location, so people know how to indicate that MA trajectories are not joint with, e.g., NH trajectories, but are joint across horizons for each location? And maybe also give an example of a submission of trajectories that are joint across both locations and horizons?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add more details re. submitting samples from a marginal/joint distribution with an example data table.