generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DASB-667-Add ability to select message service in report sink service: AWS SNS/SQS #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sages() function; begin README.md update with AWS SQS configuration details
…erties - Renamed ServiceBusMessage.kt to MessageBase.kt for broader applicability across messaging systems. - Updated codebase references to reflect these changes. - Added missing properties to the header comment in CreateReportMessage.kt.
… bus library log unsupported message system from config and added health check for it Removed com.microsoft.azure:azure-servicebus:3.6.7 and replaced it with com.azure:azure-messaging-servicebus:7.15.0. Updated Healthcheck.kt to use serviceBusException from the com.azure:azure-messaging-servicebus:7.15.0 Added com.sun.activation:javax.activation:1.2.0 to support MimeType checking. Updated some library versions to address vulnerabilities. Added while loop back to AWSSQS.kt
Replaced runBlocking with CoroutineScope in AWS SQS module to ensure non-blocking execution, which was blocking health endpoint to fail for AWS SQS. Refactored HealthCheck.kt by adding private functions to check and update health status for all supported services Added compileHealthChecks() to compile and return health status of all services in a single response.
Quality Gate passedIssues Measures |
mkrystof
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
AWS SNS/SQS
plugin and includes several key updates:AWS SQS
to listen to messages from the configured SQS service.AWS SNS/SQS
.README.md