-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of top level tests #484
Conversation
upload-server/cmd/main_test.go
Outdated
os.Setenv("AWS_SECRET_ACCESS_KEY", "minioadmin") | ||
|
||
os.Setenv("EDAV_STORAGE_ACCOUNT", "devstoreaccount1") | ||
os.Setenv("EDAV_STORAGE_KEY", "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the example key from azurite, public here
Fortify Scan Results🔴 Status: ❌ Failed (Critical Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
- azure -> s3 - s3 -> azure - file -> s3
Fortify Scan Results🔴 Status: ❌ Failed (Critical Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🔴 Status: ❌ Failed (Critical Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
1 similar comment
Fortify Scan Results🔴 Status: ❌ Failed (Critical Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🔴 Status: ❌ Failed (Critical Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Fortify Scan Results🟢 Status: 🔍 (Low Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cleanup but looks great overall
@@ -86,7 +86,7 @@ func InitConfigCache(ctx context.Context, appConfig appconfig.AppConfig) error { | |||
} | |||
} | |||
|
|||
if appConfig.S3Connection != nil { | |||
if appConfig.S3Connection != nil && appConfig.S3ManifestConfigBucket != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup: favor S3ManifestConfigFolder
over S3ManifestConfigBucket
and remove S3ManifestConfigBucket
Getting this when running locally |
Fortify Scan Results🟢 Status: 🔍 (Low Issues) Summary
🛠 Action RequiredPlease address the identified vulnerabilities before merging this pull request. Expand the "Detailed Results" section below for more information. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Example of running a local cross cloud test:
Note
A directory called test-bucket must be in the _data directory for the local volume for minio, where this is will differ between systems.