generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deliminates data stream and route with an underscore #533
Merged
cfarmer-fearless
merged 2 commits into
main
from
UPLOAD-1745/bugfix-data-stream-route-concat
Oct 18, 2024
Merged
deliminates data stream and route with an underscore #533
cfarmer-fearless
merged 2 commits into
main
from
UPLOAD-1745/bugfix-data-stream-route-concat
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfarmer-fearless
requested review from
whytheplatypus,
cyber-decker and
thetif
October 15, 2024 21:19
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
whytheplatypus
requested changes
Oct 16, 2024
thetif
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
whytheplatypus
approved these changes
Oct 17, 2024
cfarmer-fearless
deleted the
UPLOAD-1745/bugfix-data-stream-route-concat
branch
October 18, 2024 17:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses an issue with how we use filenames to define data streams and routes for manifest validation. Currently, data streams and routes provided in a sender manifest are used to read in the manifest config json file by joining the data stream and route strings with a "-" (dash) character. This made it difficult to determine the datastream and route given the filename since some data streams had dashes within their values. This allowed for unintended behavior in the UI by allowing some invalid inputs to be deemed valid.
For example, if we wanted to pick the datastream "covid-all-monthly-vaccination" and the route of "csv", we could say the datastream is actually "covid-all" and the route is "monthly-vaccination-csv". The service would simple concatinate these two values with a dash, and would be able to resolve the json file. Obviously, this input combination is invalid and the user should instead see a "not found" message.
To fix this, I've renamed all of the V2 config files to use an "_" (underscore) delimiter between the datastream and route instead of a dash. That way, it's more clear where the two parts of information are, and gives the desired behavior in the UI.