deliminates data stream and route with an underscore

[cfarmer-fearless]

This patch addresses an issue with how we use filenames to define data streams and routes for manifest validation. Currently, data streams and routes provided in a sender manifest are used to read in the manifest config json file by joining the data stream and route strings with a "-" (dash) character. This made it difficult to determine the datastream and route given the filename since some data streams had dashes within their values. This allowed for unintended behavior in the UI by allowing some invalid inputs to be deemed valid.

For example, if we wanted to pick the datastream "covid-all-monthly-vaccination" and the route of "csv", we could say the datastream is actually "covid-all" and the route is "monthly-vaccination-csv". The service would simple concatinate these two values with a dash, and would be able to resolve the json file. Obviously, this input combination is invalid and the user should instead see a "not found" message.

To fix this, I've renamed all of the V2 config files to use an "_" (underscore) delimiter between the datastream and route instead of a dash. That way, it's more clear where the two parts of information are, and gives the desired behavior in the UI.

[fortify-pr-scan]

Fortify Scan Results

🟢 Status: ✅ Passed

Summary

• 🚨 Critical Issues: 0
• 🛑 High Issues: 0
• ⚠️ Medium Issues: 0
• 🔍 Low Issues: 0

✅ No Action Required

No vulnerabilities were identified in this scan.

Detailed Results

📂 Scanned Path(s)

upload-server

📊 Detailed Scan Results

sourceanalyzer is installed.
FPRUtility is installed.
fortifyclient is installed.
Using Fortify Source Analyzer to scan the code from upload-server. Results will be upload-server.fpr.
Printing the results using Fortify FPRUtility, FPRUtility summarizes and translate results.
Summary of all issues:

Total for all categories => 0 Issues

****************************************************
Number of critical issues:
No issues matched search query.
****************************************************
Number of high issues:
No issues matched search query.
****************************************************
Number of medium issues:
No issues matched search query.
****************************************************
Number of low issues:
No issues matched search query.
****************************************************

Details of all issues in csv format:

[thetif]

LGTM

[fortify-pr-scan]

Fortify Scan Results

🟢 Status: ✅ Passed

Summary

• 🚨 Critical Issues: 0
• 🛑 High Issues: 0
• ⚠️ Medium Issues: 0
• 🔍 Low Issues: 0

✅ No Action Required

No vulnerabilities were identified in this scan.

Detailed Results

📂 Scanned Path(s)

upload-server

📊 Detailed Scan Results

sourceanalyzer is installed.
FPRUtility is installed.
fortifyclient is installed.
Using Fortify Source Analyzer to scan the code from upload-server. Results will be upload-server.fpr.
Printing the results using Fortify FPRUtility, FPRUtility summarizes and translate results.
Summary of all issues:

Total for all categories => 0 Issues

****************************************************
Number of critical issues:
No issues matched search query.
****************************************************
Number of high issues:
No issues matched search query.
****************************************************
Number of medium issues:
No issues matched search query.
****************************************************
Number of low issues:
No issues matched search query.
****************************************************

Details of all issues in csv format: