generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple Delivery Targets From Route Groups #535
Draft
cfarmer-fearless
wants to merge
2
commits into
main
Choose a base branch
from
UPLOAD-1806/decoupled-delivery-targets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
Fortify Scan Results🟢 Status: ✅ Passed Summary
✅ No Action RequiredNo vulnerabilities were identified in this scan. Detailed Results📂 Scanned Path(s)upload-server 📊 Detailed Scan Results
|
@@ -54,7 +54,7 @@ func ProcessFileReadyEvent(ctx context.Context, e *event.FileReady) error { | |||
} | |||
dataStreamId := metadata.GetDataStreamID(e.Metadata) | |||
dataStreamRoute := metadata.GetDataStreamRoute(e.Metadata) | |||
d, ok := delivery.GetDestinationTarget(dataStreamId, dataStreamRoute, e.DestinationTarget) | |||
d, ok := delivery.GetGroupTarget(dataStreamId, dataStreamRoute, e.DestinationTarget) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any concerns with reducing this down to delivery.GetTarget(e.DestinationTarget)
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an iteration on the deliver configuration schema. The goal is to decouple delivery targets from routing groups. This will improve robustness by preventing possible misconfiguration of creating multiple delivery targets with the same name. With this, we want to make sure the server fails to start if the deliver yml is misconfiguration in this way.