generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt Use Of Dates With idata
Objects
#30
Open
AFg6K7h4fhy2
wants to merge
14
commits into
main
Choose a base branch
from
25-attempt-use-of-dates-with-idata-objects
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge name of idata object to include wo dates
…s; add another option w/ pl duration to experimentation file
Forecasts in this PR are implicitly assumed to be sequential days — not weeks, 2-weeks, a sequence of Saturdays, etc... Other resolution may be supported. Some critical tasks of this PR include (some of these already exist, albeit inadequately):
Key considerations:
|
From DB:
|
Some notes extracted from the experimentation file for adding dates to
NOTE: # idata.observed_data.sizes["obs_dim_0"] is suggested by Arviz over
# idata.observed_data["obs_dim_0"].size
idata.observed_data.sizes
# output: Frozen({'obs_dim_0': 488})
# idata.observed_data.dims gets one:
# output: FrozenMappingWarningOnValuesAccess({'obs_dim_0': 488})
# ^ "obs_col" name still needed ^
|
…ntation files by dates addition method
…; rename idata modifications and idata to tidy formatting
damonbayer
reviewed
Oct 24, 2024
…more similar to DHMs compact code, now reverting change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for this will be found here: #29
This PR ought to be merged before further work on #9 occurs.