Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Generating an Empty Report in Convert Step #15223

Closed
1 task
arnejduranovic opened this issue Jul 17, 2024 · 1 comment
Closed
1 task

Support Generating an Empty Report in Convert Step #15223

arnejduranovic opened this issue Jul 17, 2024 · 1 comment
Assignees
Labels
platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality

Comments

@arnejduranovic
Copy link
Collaborator

arnejduranovic commented Jul 17, 2024

User Story

As an RS developer, I would like to be able to generate an empty report so that lineages work correctly.

Description/Use Case

Currently, the code only support generating an empty report as part of sending something to receiver (i.e. they're on batch schedule and always want a report even if there are no items). However, the convert step also needs to be able to generate an empty report in the following situations:

  • the submitted report was completely empty
  • the hl7 message was unparseable

The empty report must be generated because otherwise the report lineage doesn't work and the action logs from the convert step are not visible.

Dev Notes

ActionHistory.trackGeneratedEmptyReport already exists and overload likely can get created to support this. Another option is to remove exceptions that are based on assumptions that a report cannot have empty item lineages.

Search for ticket number in code, there is a comment.

Acceptance Criteria

  • Convert step updated to generate an empty report and report lineage (no item lineage) when certain conditions are met
@arnejduranovic arnejduranovic added the platform Platform Team label Jul 17, 2024
@arnejduranovic arnejduranovic changed the title Support Generating an Empty Report Support Generating an Empty Report in Convert Step Jul 17, 2024
@arnejduranovic arnejduranovic added the ready-for-refinement Ticket is a point where we can productively discuss it label Jul 17, 2024
@Andrey-Glazkv
Copy link
Collaborator

@arnejduranovic arnejduranovic added the tech-debt Anything that is purely a technical issue and does not affect functionality label Jul 22, 2024
@Andrey-Glazkv Andrey-Glazkv removed the ready-for-refinement Ticket is a point where we can productively discuss it label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality
Projects
Development

No branches or pull requests

5 participants