-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15223: generate empty in convert #16137
15223: generate empty in convert #16137
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Integration Test Results 53 files 53 suites 27m 38s ⏱️ Results for commit 42e5870. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 One small comment:
I wonder if there's any tech debt in ActionHistory.kt
worth ticketing. I remember getting a little lost / confused when tracking a created empty report in other steps.
Separate but related, should we scope some tickets for using this new function in other places we generate an empty report (e.g. FHIRDestinationFilter.kt
and FHIRReceiverFilter.kt
)? Will spend a little more time thinking this over tomorrow.
@thetaurean 100% think there are tech debt tickets to be made for action history but I have always been unsure where to start since I think there could be an argument to simply rewrite the whole thing. For the other pipeline steps, maybe? This spot in in convert is a little unique in the sense that its only part of the pipeline where the number of items is unknown in case of an error |
Quality Gate passedIssues Measures |
This PR updates the code so that when an empty report (or any situation where the number of items cannot be determined) makes it to the convert step.
Test Steps:
There are a integration tests that covers this, but as the pipeline is currently structured this is hard to test manually as the report function will synchronously fail.
Changes
trackEmptyReport
that can be used anywhere in the pipelineChecklist
Testing
./prime test
or./gradlew testSmoke
against local Docker ReportStream container?npm run lint:write
?Process
Linked Issues
To Be Done
Specific Security-related subjects a reviewer should pay specific attention to