Add test cases for partially delivered submissions #16055

thetaurean · 2024-09-30T16:13:50Z

This PR adds tests cases to properly cover a partially delivered submission. It also relabels 2 old tests that are actually testing in-flight submissions. The bug that this PR fixes was actually solved in prior PR(s), but it only added tests for pipeline output and not submission history.

Test Steps:

Run tests

Changes

Added proper test cases for partially delivered submissions
Marked the replaced tests cases with TODO and updated their description
Minor update to ReportNodeBuilder.kt that got lumped in here for reasons

Checklist

Testing

Tested locally?
Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
Added tests?

Linked Issues

Fixes [BUG] Submission History API doesn't show Filtered reports #15645

To Be Done

[BUG] Wrong status in submission history for partially delivered in-flight submissions #16054

github-actions · 2024-09-30T16:14:06Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

github-actions · 2024-09-30T16:28:13Z

Test Results

1 241 tests +2 1 237 ✅ +2 7m 42s ⏱️ -3s
162 suites ±0 4 💤 ±0
162 files ±0 0 ❌ ±0

Results for commit dee5da9. ± Comparison against base commit 5025bf5.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.

gov.cdc.prime.router.history.azure.SubmissionFunctionIntegrationTests ‑ it should return a history for partially delivered submission (for legacy route step)()

gov.cdc.prime.router.history.azure.SubmissionFunctionIntegrationTests ‑ it should return a history for an in-flight submission (for legacy route step)()
gov.cdc.prime.router.history.azure.SubmissionFunctionIntegrationTests ‑ it should return a history for an in-flight submission()
gov.cdc.prime.router.history.azure.SubmissionFunctionIntegrationTests ‑ it should return a history for an partially delivered submission (for legacy route step)()

♻️ This comment has been updated with latest results.

github-actions · 2024-09-30T16:48:35Z

Integration Test Results

53 files ±0 53 suites ±0 27m 38s ⏱️ +25s
410 tests ±0 401 ✅ ±0 9 💤 ±0 0 ❌ ±0
413 runs ±0 404 ✅ ±0 9 💤 ±0 0 ❌ ±0

Results for commit dee5da9. ± Comparison against base commit 5025bf5.

♻️ This comment has been updated with latest results.

david-navapbc · 2024-10-03T23:52:36Z

Archive.zip

I pulled master and merged it into a local copy of this branch and got the test error you see in the attached report.

thetaurean · 2024-10-04T15:57:49Z

Archive.zip

I pulled master and merged it into a local copy of this branch and got the test error you see in the attached report.

Looks like a connection refused on your local blob container. Investigating further but passing in CI so might be a local issue.

david-navapbc · 2024-10-04T17:53:16Z

prime-router/src/test/kotlin/history/azure/SubmissionFunctionIntegrationTests.kt

@@ -153,7 +307,7 @@ class SubmissionFunctionIntegrationTests {
        val historyNode = JacksonMapperUtilities.defaultMapper.readTree(history.body.toString())
        assertThat(
            historyNode.get("overallStatus").asText()
-        ).isEqualTo(DetailedSubmissionHistory.Status.PARTIALLY_DELIVERED.toString())
+        ).isEqualTo(DetailedSubmissionHistory.Status.PARTIALLY_DELIVERED.toString()) // TODO: should be RECEIVED


why the TODO?

Related to the todo in the function header (#16054)

david-navapbc · 2024-10-04T17:53:24Z

prime-router/src/test/kotlin/history/azure/SubmissionFunctionIntegrationTests.kt

@@ -95,15 +248,16 @@ class SubmissionFunctionIntegrationTests {
        val historyNode = JacksonMapperUtilities.defaultMapper.readTree(history.body.toString())
        assertThat(
            historyNode.get("overallStatus").asText()
-        ).isEqualTo(DetailedSubmissionHistory.Status.PARTIALLY_DELIVERED.toString())
+        ).isEqualTo(DetailedSubmissionHistory.Status.PARTIALLY_DELIVERED.toString()) // TODO: should be RECEIVED


why the TODO?

Related to the todo in the function header (#16054)

david-navapbc · 2024-10-04T17:55:43Z

prime-router/src/test/kotlin/common/ReportNodeBuilder.kt

@@ -189,6 +208,7 @@ class ReportNodeBuilder {
        }
    }
    lateinit var theAction: TaskAction


why are some of these lateinit and some of these are nullable vars?

Good point! I'm going to take a 2nd look; on first (2nd) glance they should probably both be nullable since null is a valid state in either case.

david-navapbc

lgtm!

sonarcloud · 2024-10-09T16:07:34Z

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Updated submission history test cases

446f6d5

thetaurean added the platform Platform Team label Sep 30, 2024

thetaurean requested a review from a team as a code owner September 30, 2024 16:13

thetaurean temporarily deployed to staging September 30, 2024 16:14 — with GitHub Actions Inactive

Andrey-Glazkv assigned david-navapbc Oct 1, 2024

Merge branch 'master' into platform/thetaurean/15645-partially-delivered

b4ceab5

thetaurean temporarily deployed to staging October 4, 2024 15:55 — with GitHub Actions Inactive

david-navapbc reviewed Oct 4, 2024

View reviewed changes

Merge branch 'master' into platform/thetaurean/15645-partially-delivered

2906942

thetaurean requested a review from david-navapbc October 7, 2024 17:18

thetaurean temporarily deployed to staging October 7, 2024 17:21 — with GitHub Actions Inactive

Rework theNextAction members

ecc6d50

thetaurean temporarily deployed to staging October 8, 2024 01:14 — with GitHub Actions Inactive

david-navapbc approved these changes Oct 8, 2024

View reviewed changes

arnejduranovic approved these changes Oct 8, 2024

View reviewed changes

Merge branch 'master' into platform/thetaurean/15645-partially-delivered

dee5da9

thetaurean enabled auto-merge October 9, 2024 15:41

thetaurean temporarily deployed to staging October 9, 2024 15:42 — with GitHub Actions Inactive

thetaurean merged commit ffbe8be into master Oct 9, 2024
22 checks passed

thetaurean deleted the platform/thetaurean/15645-partially-delivered branch October 9, 2024 16:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test cases for partially delivered submissions #16055

Add test cases for partially delivered submissions #16055

thetaurean commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

david-navapbc commented Oct 3, 2024

thetaurean commented Oct 4, 2024

david-navapbc Oct 4, 2024

thetaurean Oct 4, 2024

david-navapbc Oct 4, 2024

thetaurean Oct 4, 2024

david-navapbc Oct 4, 2024

thetaurean Oct 4, 2024

david-navapbc left a comment

sonarcloud bot commented Oct 9, 2024

Add test cases for partially delivered submissions #16055

Add test cases for partially delivered submissions #16055

Conversation

thetaurean commented Sep 30, 2024 • edited Loading

Changes

Checklist

Testing

Linked Issues

To Be Done

github-actions bot commented Sep 30, 2024 • edited Loading

Dependency Review

OpenSSF Scorecard

Scanned Manifest Files

github-actions bot commented Sep 30, 2024 • edited Loading

Test Results

github-actions bot commented Sep 30, 2024 • edited Loading

Integration Test Results

david-navapbc commented Oct 3, 2024

thetaurean commented Oct 4, 2024

david-navapbc Oct 4, 2024

Choose a reason for hiding this comment

thetaurean Oct 4, 2024

Choose a reason for hiding this comment

david-navapbc Oct 4, 2024

Choose a reason for hiding this comment

thetaurean Oct 4, 2024

Choose a reason for hiding this comment

david-navapbc Oct 4, 2024

Choose a reason for hiding this comment

thetaurean Oct 4, 2024

Choose a reason for hiding this comment

david-navapbc left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 9, 2024

Quality Gate passed

thetaurean commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading