Check submission table when computing submission history #16200
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Integration Test Results 53 files 53 suites 27m 25s ⏱️ Results for commit 80a4e91. ♻️ This comment has been updated with latest results. |
thetaurean
force-pushed
the
platform/thetaurean/15822-submission-history-sources
branch
from
7e96b98
to
3a4225d
Compare
thetaurean
force-pushed
the
platform/thetaurean/15822-submission-history-sources
branch
from
3a4225d
to
d1f6f5c
Compare
|
|
||
| return if (submission == null) { | ||
| logger.error(ex) | ||
| HttpUtilities.notFoundResponse(request, ex.message) |
There was a problem hiding this comment.
why return the exception message to the caller?
The project is open source so it's not really an OWASP issue in the way it would be were our project proprietary. As such feel free to leave this alone if you feel strongly.
my view is - in general - to not return anything to the caller directly tied to a facet of system state and/or implementation detail unless the caller needs to have that information for some specific reason.
There was a problem hiding this comment.
I agree with you however this was pre-existing code so I didn't feel comfortable changing it.
For the most part this is catching exceptions that we throw, so the error messages are things we set. Though IllegalStateException is pretty broad and could probably occur unexpectedly.
arnejduranovic
temporarily deployed
to
staging
GitHub Actions
Inactive
|
arnejduranovic
deleted the
platform/thetaurean/15822-submission-history-sources
branch
This PR updates the submission history code to check the new submission table in azure storage when a submissionId is not found in the primary postgres database.
Test Steps:
Changes
SubmissionclassChecklist
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?Linked Issues