Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexion/jgilmore/16196-add-environment-variable-for-default encoding #16235

Conversation

GilmoreA6
Copy link
Collaborator

This PR Adds Environment variable "JAVA_OPTS" with value ""-Dfile.encoding=UTF-8" to all environments so the deployed environments are consistent with local environments which have the JAVA_OPTS set in prime-router/local.settings.json

Test Steps:

  1. Deploy branch to demo environment (currently deployed to demo1)
  2. Verify that "JAVA_OPTS" env variable is set with value "-Dfile.encoding=UTF-8"

Changes

  • Add Environment variable "JAVA_OPTS" with value ""-Dfile.encoding=UTF-8" to all env terraform files
  • Add Integration test for HL7 to FHIR for ORU

Testing

  • [x ] Tested locally?
  • [x ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • [x ] Added tests?

Process

  • [x ] DevOps team has been notified if PR requires ops support?

Linked Issues

@GilmoreA6 GilmoreA6 requested review from a team as code owners October 15, 2024 18:55
Copy link

github-actions bot commented Oct 15, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Oct 15, 2024

Test Results

1 242 tests  ±0   1 238 ✅ ±0   7m 37s ⏱️ -14s
  162 suites ±0       4 💤 ±0 
  162 files   ±0       0 ❌ ±0 

Results for commit 0cb1704. ± Comparison against base commit 6727053.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 15, 2024

Integration Test Results

 53 files  ±0   53 suites  ±0   27m 29s ⏱️ -31s
411 tests +1  402 ✅ +1  9 💤 ±0  0 ❌ ±0 
414 runs  +1  405 ✅ +1  9 💤 ±0  0 ❌ ±0 

Results for commit 0cb1704. ± Comparison against base commit 6727053.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@devopsmatt devopsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Oct 15, 2024

@GilmoreA6 GilmoreA6 merged commit f283cf3 into master Oct 15, 2024
25 checks passed
@GilmoreA6 GilmoreA6 deleted the Flexion/jgilmore/16196-add-enviornment-variable-for-default-encoding branch October 15, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'µ' character gets garbled after conversion from HL7 to FHIR
3 participants