Add sender transform to remove leading zeros for CDPH NBS NM data type #16296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Test Results1 249 tests 1 245 ✅ 7m 52s ⏱️ Results for commit 418291e. ♻️ This comment has been updated with latest results. |
victor-chaparro
approved these changes
Oct 21, 2024
Integration Test Results 53 files 53 suites 27m 46s ⏱️ Results for commit 418291e. ♻️ This comment has been updated with latest results. |
6 tasks
|
GilmoreA6
deleted the
Flexion/jgilmore/1454-leading-zeroes-for-nm-date-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sender transform that removes leading zeros from values stored in valueQuantity.value in order to prevent the destination-filter step from throwing error "message":"ca.uhn.fhir.parser.DataFormatException: HAPI-1861: Failed to parse JSON encoded FHIR content: Invalid numeric value: Leading zeroes not allowed"
Test Steps:
Changes
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?