Replace organization query with whoami query #6109
Conversation
| phone | ||
| deviceTypes { | ||
| whoami { |
There was a problem hiding this comment.
The organization is now nested in whoami, no fields were actually changed.
frontend/src/app/Settings/types.d.ts
Outdated
| @@ -150,3 +150,8 @@ type OrganizationType = | |||
| | "camp" | |||
| | "lab" | |||
| | "other"; | |||
|
|
|||
There was a problem hiding this comment.
Could we move this type declaration out of the global import and put it in a named .ts file? The Typescript team discourages this pattern since there might be compilation issues without a corresponding JS file.
There was a problem hiding this comment.
I didn't know that the d.ts use was discouraged in typescript because the context of the type can be messed up. Sounds like these files are more like a result of typescript being compile into JS.
There was a problem hiding this comment.
Yeah so based on the reading I did, the .d.ts files are there for libraries where typescript and javascript files are sitting side by side. In cases where JS files are necessary, adding the .d.ts files allows you to still have access to the relevant types while not requiring those files to be typescript files.
Based on what I found this pattern isn't as big an issue for applications since the main antipattern is global access when libraries are imported (which would make those variables available at the global namespace even outside the library) but I think it's still worth it to make it explicit where these new types are coming from just so there isn't any confusion / to avoid possible namespace collision issues.
frontend/src/app/Settings/types.d.ts
Outdated
| @@ -150,3 +150,8 @@ type OrganizationType = | |||
| | "camp" | |||
| | "lab" | |||
| | "other"; | |||
|
|
|||
There was a problem hiding this comment.
I didn't know that the d.ts use was discouraged in typescript because the context of the type can be messed up. Sounds like these files are more like a result of typescript being compile into JS.
|
Kudos, SonarCloud Quality Gate passed! |
BACKEND PULL REQUEST
Related Issue
Changes Proposed
organizationquery withwhoamioperations.graphqlAdditional Information
organizationquery to make it fetch by id rather than user contextTesting