generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 99717-49 Local Code to 76030-6 LOINC mapping #1453
Open
jbiskie
wants to merge
14
commits into
main
Choose a base branch
from
add-mpsii-comments-mapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+280
−125
Open
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b1f437f
Add 99717-49 local code mapping
jbiskie 391264d
WIP - moving coding map to json definition
jbiskie 59dfdcc
Remove hardcoded mapping, add mapping to test class
jbiskie 132c27f
Move codingMap to a local variable; WIP - add failing tets for bad ar…
jbiskie a13fe6d
NullPointerException from rule
jorg3lopez 3e5d322
get exception message
jorg3lopez eca775b
Refactor getMapFromArgs to reduce complexity; Update tests to check f…
jbiskie 1cba293
Move exception throwing inline.
jbiskie 938f82c
Update MapLocalObservationCodesTest.groovy
luis-pabon-tf 1540465
Update MapLocalObservationCodesTest.groovy
luis-pabon-tf b860a23
Merge branch 'main' into add-mpsii-comments-mapping
jbiskie 39aa1cc
Merge branch 'main' into add-mpsii-comments-mapping
jbiskie 2a961d4
Add mpsii comments mapping refactor (#1477)
jorg3lopez 3ca73a5
inline extraction
jorg3lopez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is only used once, it has a single line and the content is pretty straightforward. Does it need to extracted into its own function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. I'll inline the extracting method and keep the logging one as is to keep the logging logic in one area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant is that we probably don't need
logUnmappedLocalCode
as it's adding more abstraction without the benefits. You could directly calllogger.logWarning
without putting it into its own function