Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things, one which is necessary another which may be up for discussion but does appear to be necessary if we are passing in long pmfs through a config...
validate_pmf()
function.all.equal()
needs to be wrapped inisTRUE()
because it returns either TRUE or a character with difference (alternatively we could use that error message here, but I like our custom one). https://www.rdocumentation.org/packages/base/versions/3.6.2/topics/all.equalThe up for debate thing is that:
Open to other suggestions e.g. for the pipeline we could one off load the rda from the
wwinference
package, use the package default, or compute directly but in general I think we want thewwinference
package to allow users to specify via a config a long delay so tolerance can be a bit higher IMO.