Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing artifact and setting retention days to 7 #230

Conversation

gvegayon
Copy link
Member

This pull request includes updates to the GitHub Actions workflow and documentation for the wwinference package. The most important changes involve modifying the workflow for posting pages artifacts to pull requests and updating the NEWS.md file to reflect these internal changes.

Workflow Updates:

  • .github/workflows/pkgdown.yaml: Added name and retention-days to the upload-pages-artifact step to specify the artifact name and retention period (7 days now).
  • .github/workflows/pkgdown.yaml: Simplified the post-page-artifact job by removing unnecessary steps and using CDCgov/cfa-actions/post-artifact to post the artifact with the name github-pages.

Documentation Updates:

  • NEWS.md: Added an entry under the development version wwinference 0.1.0.99 to document the internal changes related to the workflow update for posting pages artifacts to pull requests.

@gvegayon gvegayon linked an issue Oct 23, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 23, 2024

Thank you for your contribution @gvegayon 🚀! Your github-pages is ready for download 👉 here 👈!
(The artifact expires on 2024-10-30T20:04:37Z. You can re-generate it by re-running the workflow here.)

@gvegayon gvegayon marked this pull request as ready for review October 23, 2024 18:24
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change @gvegayon

.github/workflows/pkgdown.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gvegayon!

@dylanhmorris dylanhmorris merged commit ea85773 into main Oct 23, 2024
10 checks passed
@dylanhmorris dylanhmorris deleted the 229-switch-to-using-cfa-actionspost-artifact-for-artifact-posting-on-prs branch October 23, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to using cfa-actions/post-artifact for artifact posting on PRs
2 participants