Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish phase 1 dashboard work #574

Closed
1 of 2 tasks
briri opened this issue Apr 25, 2024 · 6 comments
Closed
1 of 2 tasks

Finish phase 1 dashboard work #574

briri opened this issue Apr 25, 2024 · 6 comments
Assignees
Labels

Comments

@briri
Copy link
Collaborator

briri commented Apr 25, 2024

Add the final elements of the DMP Upload dashboard:

  • Slide out information card
  • Filters

@fraserclark please make the PR to the v5 branch when you're ready

@briri
Copy link
Collaborator Author

briri commented May 10, 2024

Sorry for the delay in getting a sample of what the related works JSON looks like to you.

Here is a recent DMP one of our pilot project partners uploaded through the phase 1 functionality. It has 8 related works that need review: https://api.dmphub.uc3prd.cdlib.net/dmps/10.48321/D13BEA529C

The related works can be found in the dmphub_modifications array

@fraserclark
Copy link
Collaborator

@briri I've added the pull request now

#589

@briri
Copy link
Collaborator Author

briri commented May 22, 2024

@fraserclark I merged your PR and then needed to make a few minor adjustments to the way related_works were being checked/handled and also with the grant_id. I think maybe you had old data on your local or were working with some older registered plans that had some outdated metadata.

For reference, those changes are in my PR #594 no need for you to do anything with it, just an FYI

@mariapraetzellis
Copy link
Collaborator

mariapraetzellis commented May 22, 2024

My notes from testing the slider:

  1. I have 3 small formatting & text changes:
  • Increase the margins of the Grant ID field. It is currently displaying too close to the right margin of the slider.
Screen Shot 2024-05-21 at 1 15 26 PM
  • Change the field title of the "Last Updated" field to "Last Edited" to match the wording from the table
  • Remove extra “-“ in the Project Dates field: “Start: 2021-01-15 - End: 2024-12-31”
  1. Is it possible to add an "X" to close the slider window so you don’t have to scroll to the bottom in order to close the window?

  2. I found one possible bug. I created a new plan via the upload feature but did not generate a DMP ID. Howver, there is still a DMP ID included in the slider. https://dmptool-stg.cdlib.org/dashboard/dmp/20240521-2394df1c2e33

@briri
Copy link
Collaborator Author

briri commented May 22, 2024

@jupiter007 I just pushed the changes Maria request to my PR #594. Can you please review when you have a minute?

@mariapraetzellis mariapraetzellis self-assigned this May 22, 2024
@mariapraetzellis
Copy link
Collaborator

The changes all look good, thanks @briri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants