Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5.16 rc2 #594

Merged
merged 14 commits into from
May 22, 2024
Merged

V5.16 rc2 #594

merged 14 commits into from
May 22, 2024

Conversation

briri
Copy link
Collaborator

@briri briri commented May 20, 2024

  • Updates to all gem and JS dependencies
  • Unlocked the MySQL gem so that it could upgrade to 0.5.6
  • Updated the drafts_controller so that it calls out to the DMPHub to fetch related works found by the harvesters upon initial load
  • removed curly braces that did not need to be there in dashboards.js
  • fixed some issues with the display of the related works count in the grey text that appears under the DMP title (See screenshot).
  • fixed issue with the grant id display in the slide out modal
  • fixed issue with the z-index of the new slide out modal (DMP ID urls were showing through the modal)

@briri briri requested a review from jupiter007 May 20, 2024 23:55
@jupiter007
Copy link
Collaborator

Hi Brian. The changes look good to me.

@briri briri mentioned this pull request May 22, 2024
2 tasks
@jupiter007
Copy link
Collaborator

@briri I'm wondering whether the "close" button might look better if outside of the content div.

I've included a screenshot of the before and after

image

I also added a hover effect on the close button to make it more visually interactive.

If you like the change, you can just update the css to be:

#quick-view-view h3 .form-actions button {
  border-radius: 50%;
  position: absolute;
  right: 10px;
  top: 10px;
  height: 32px;
  width: 32px;
  font-size: .8rem;
  padding: 0;
}

#quick-view-view h3 .form-actions button:hover {
  background-color: #ccc;
}

@jupiter007
Copy link
Collaborator

Also, since we're using Sass, you can put the css in the sass nested format for more readability:

#quick-view-view {
  h3 {
    display: flex;
    align-items: flex-start;
    justify-content: space-between;
    flex-wrap: nowrap;

    .form-actions {
      margin-top: 0;
      padding-top: 0;
      padding-left: 0;

      button {
        border-radius: 50%;
        position: absolute;
        right: 10px;
        top: 10px;
        height: 32px;
        width: 32px;
        font-size: .8rem;
        padding: 0;

        &:hover {
          background-color: #ccc;
        }
      }
    }
  }

  p.preview-grant {
    max-width: 100%;
    overflow-wrap: anywhere;
  }
}

@briri briri merged commit f1a91b9 into v5 May 22, 2024
2 of 8 checks passed
@briri briri deleted the v5.16-rc2 branch May 22, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants