-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5.16 rc2 #594
Conversation
briri
commented
May 20, 2024
- Updates to all gem and JS dependencies
- Unlocked the MySQL gem so that it could upgrade to 0.5.6
- Updated the drafts_controller so that it calls out to the DMPHub to fetch related works found by the harvesters upon initial load
- removed curly braces that did not need to be there in dashboards.js
- fixed some issues with the display of the related works count in the grey text that appears under the DMP title (See screenshot).
- fixed issue with the grant id display in the slide out modal
- fixed issue with the z-index of the new slide out modal (DMP ID urls were showing through the modal)
… to the project overview page
Hi Brian. The changes look good to me. |
@briri I'm wondering whether the "close" button might look better if outside of the content div. I've included a screenshot of the before and after I also added a hover effect on the close button to make it more visually interactive. If you like the change, you can just update the css to be:
|
Also, since we're using Sass, you can put the css in the sass nested format for more readability:
|