Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/pdf grover #616

Merged
merged 24 commits into from
Jun 26, 2024
Merged

Bug/pdf grover #616

merged 24 commits into from
Jun 26, 2024

Conversation

briri
Copy link
Collaborator

@briri briri commented Jun 25, 2024

Fixes #604.

Changes proposed in this PR:

  • Replace use of wicked_pdf gem which used the now defunct wkhtmltopdf package with the grover gem which uses puppeteer and headless chrome. This occurs in the following files: plan_exports_controller.rb, pdf_publisher_job.rb and public_pages_controller
  • Updated Gemfile to remove the aforementioned gems and add grover
  • Removed wkhtmltopdf from Rails config
  • Added an initializer to setup grover properly
  • Add the publisher_job_status field to the templates table and added narrative to the template model so that we can store the PDF version of a template in ActiveStorage
  • Update the Template publication workflow so that it pre-renders the template as a PDF and stores it in ActiveStorage
  • Update both the public facing "Funder Requirements" and "Public Plans" pages to return the pre-rendered PDFs from ActiveStorage when available.
  • Update the PdfPublisherJob to use Grover to build PDFs
  • Added Roboto and Tinos fonts
  • Added new tasks for Capistrano so that it will install Chrome on the server if it does not already exist and will also install the Roboto and Tinos fonts
  • Added Rake task to pre-render all public templates
  • Updated gem and JS dependencies

briri added 24 commits June 18, 2024 15:13
… plans. Updated template to store PDF in active storage when published for public downloads
…t rebuilds the font index after deploying. Updates to get chrome and fonts installed in Docker
@briri briri merged commit 01ff79c into v5 Jun 26, 2024
0 of 8 checks passed
@briri briri deleted the bug/pdf-grover branch June 26, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant