forked from DMPRoadmap/roadmap
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/pdf grover #616
Merged
Merged
Bug/pdf grover #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plans. Updated template to store PDF in active storage when published for public downloads
…e activestorage copy of public plans
…orage rather than rendered on the fly
…t rebuilds the font index after deploying. Updates to get chrome and fonts installed in Docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #604.
Changes proposed in this PR:
wicked_pdf
gem which used the now defunctwkhtmltopdf
package with thegrover
gem which usespuppeteer
and headlesschrome
. This occurs in the following files:plan_exports_controller.rb
,pdf_publisher_job.rb
andpublic_pages_controller
grover
publisher_job_status
field to thetemplates
table and addednarrative
to thetemplate
model so that we can store the PDF version of a template in ActiveStoragePdfPublisherJob
to use Grover to build PDFsRoboto
andTinos
fonts