Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Boost 1.54 and a non reachable ticket #7765

Closed
albert-github opened this issue Oct 9, 2023 · 3 comments · Fixed by #7777
Closed

Problem with Boost 1.54 and a non reachable ticket #7765

albert-github opened this issue Oct 9, 2023 · 3 comments · Fixed by #7777

Comments

@albert-github
Copy link
Contributor

In the code we see in Point_set_processing_3/include/CGAL/mst_orient_normals.h (output: Point_set_processing_3/group___pkg_point_set_processing3_algorithms.html):

   \warning This function may fail when Boost version 1.54 is used,
   because of the following bug: https://svn.boost.org/trac/boost/ticket/9012

though https://svn.boost.org/trac/boost/ticket/9012 is not reachable

  • is this warning still valid?
  • when valid what is the correct reference?
@lrineau
Copy link
Member

lrineau commented Oct 9, 2023

What is more, Boost 1.54 is no longer supported by CGAL (but only versions >= 1.66 as of CGAL-5.6) . That warning should be removed entirely.

albert-github added a commit to albert-github/cgal that referenced this issue Oct 10, 2023
CGAL as of version 5.6 requires Boost 1.66 or higher so the warning is not valid anymore
@albert-github
Copy link
Contributor Author

I've just pushed a proposed patch, pull request #7777

@albert-github
Copy link
Contributor Author

Note in the code of Point_set_processing_3/include/CGAL/mst_orient_normals.h we also see:

#include <CGAL/boost/graph/dijkstra_shortest_paths.h> // work around a
                                                      // bug in boost
                                                      // 1.54

the question here is what to do with this / what can also be removed (I cannot do this as I cannot compile CGAL / test it).

@MaelRL MaelRL added this to the 6.0-beta milestone Oct 10, 2023
sloriot added a commit that referenced this issue Oct 25, 2023
CGAL as of version 5.6 requires Boost 1.66 or higher so the warning is
not valid anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants