Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The width of documentation of CGAL::Polygon_mesh_processing::corefine_and_compute_boolean_operations is too large #8176

Closed
lrineau opened this issue Apr 30, 2024 · 6 comments · Fixed by #8178
Assignees
Milestone

Comments

@lrineau
Copy link
Member

lrineau commented Apr 30, 2024

https://doc.cgal.org/latest/Polygon_mesh_processing/group__PMP__corefinement__grp.html#gaaeb559e2f901b418ddd563e8aace83eb

That documentation does not fit in the width of any of my screens.

That seems to be because of const std::tuple< NamedParametersOut0, NamedParametersOut1, NamedParametersOut2, NamedParametersOut3 > & nps_out = std::tuple<NamedParametersOut0,NamedParametersOut1,NamedParametersOut2,NamedParametersOut3>() that is too wide, and not wrapped by Doxygen CSS.

Same issue with CGAK-5.5.x (and even previous versions). I am surprised it was not pointed out by the review of the documentation... 😈

@lrineau lrineau added this to the 5.5.5 milestone Apr 30, 2024
@sloriot
Copy link
Member

sloriot commented Apr 30, 2024

If you use the horizontal scrolling bar it works. It's not broken. I can rename the template parameters if you want.
image

@lrineau
Copy link
Member Author

lrineau commented May 2, 2024

It is not broken, but it make the documentation really difficult to read. In particular the paragraph:

The positions of the meshes in the array output are specific to the Boolean operation to compute and Corefinement::Boolean_operation_type encodes and describes the ordering. Constructing the default array means that no Boolean operation will be done. Overwriting a default value will trigger the corresponding operation. In such a case, the address to a valid surface mesh must be provided. The optional named parameters for all output meshes are provided as a tuple and follow the same order as the array output. A call to corefine_and_compute_boolean_operations() with optional named parameters passed for output meshes should be done using make_tuple() as the types of named parameters are unspecified.

On my screen, it is really large, twice wider than the screen:
Screenshot_20240502_124729
Screenshot_20240502_124744
and it is difficult to follow the stream of the sentences, using the horizontal scrollbar.

@afabri
Copy link
Member

afabri commented May 2, 2024

Let's just change it to NPOut1

@sloriot sloriot linked a pull request May 2, 2024 that will close this issue
@afabri
Copy link
Member

afabri commented May 7, 2024

Tested in CGAL-Ic-237
I am wondering if we should not also have a shorter namespace PMP.

@lrineau
Copy link
Member Author

lrineau commented May 8, 2024

Tested in CGAL-Ic-237 I am wondering if we should not also have a shorter namespace PMP.

I plan to merge #8178. Do you think we should keep this issue open, and add another patch to have a nicer documentation? @afabri

@MaelRL MaelRL closed this as completed May 15, 2024
@lrineau lrineau modified the milestones: 5.5.5, 5.6.2 May 16, 2024
@lrineau
Copy link
Member Author

lrineau commented May 16, 2024

Tested in CGAL-Ic-237 I am wondering if we should not also have a shorter namespace PMP.

I plan to merge #8178. Do you think we should keep this issue open, and add another patch to have a nicer documentation? @afabri

Ping @afabri, you have not yet reacted to the question above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants