Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameters #8178

Merged
merged 2 commits into from
May 15, 2024
Merged

Rename parameters #8178

merged 2 commits into from
May 15, 2024

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented May 2, 2024

Fixes #8176

@sloriot sloriot linked an issue May 2, 2024 that may be closed by this pull request
The width of documentation of CGAL::Polygon_mesh_processing::corefine_and_compute_boolean_operations is too large #8176
Closed
@albert-github
Copy link
Contributor

Wouldn't it be more consistent to replace all NamedParametersOut... by NPOut... in this package?
Analogous for NamedParametersIn... rename to NPIn... and NamedParameters... to NP....

@lrineau
Copy link
Member

lrineau commented May 2, 2024

/build:fix-v1

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8178/fix/Manual/index.html

@lrineau
Copy link
Member

lrineau commented May 2, 2024

That is better. Now it fits just in the width of my screen:
https://cgal.github.io/8178/fix/Polygon_mesh_processing/group__PMP__corefinement__grp.html#gae3553532387bd3ecfbcb72f4f092c7bc

@sloriot
Copy link
Member Author

sloriot commented May 2, 2024

Wouldn't it be more consistent to replace all NamedParametersOut... by NPOut... in this package? Analogous for NamedParametersIn... rename to NPIn... and NamedParameters... to NP....

I don't have a strong opinion. I'll have to go through the logs of the review to check if that was a request from the reviewers.

@afabri
Copy link
Member

afabri commented May 2, 2024

It should also be changed for the input parameters.

@lrineau lrineau self-assigned this May 8, 2024
@lrineau lrineau added this to the 5.6.2 milestone May 8, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 8, 2024
@lrineau lrineau mentioned this pull request May 8, 2024
Closed
@sloriot
Copy link
Member Author

sloriot commented May 10, 2024

Successfully tested in CGAL-6.0-Ic-237

@sloriot sloriot added Tested and removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' Under Testing labels May 10, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 13, 2024
@lrineau lrineau merged commit 7838cde into CGAL:5.6.x-branch May 15, 2024
8 checks passed
lrineau added a commit that referenced this pull request May 15, 2024
@lrineau
Merge pull request #8178 from sloriot/PMP-shorten_params
76809fa 
Rename parameters
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 16, 2024
@lrineau lrineau deleted the PMP-shorten_params branch May 16, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lrineau lrineau

Labels
Doc bug Merged_in_6.0 Pkg::PMP Tested
Projects
None yet
Milestone
5.6.2
4 participants
@sloriot @albert-github @lrineau @afabri