GSoC2022 - Interpolated Corrected Curvatures #6760

hoskillua · 2022-07-15T13:30:15Z

Release Management

Affected package(s): PMP
Feature/Small Feature: here -- pre-approval on 2023/10/24

TODOs:

check branch size
theoretical background in the user manual
authorship

I will replace ExactPredInexactConstructs with a geometry traits template next ISA

it works fine, still need to handle if vnm is not given

Triangulation_2/examples/Triangulation_2/triangulation_prog1.cpp

sloriot · 2022-07-15T13:58:12Z

cc @dcoeurjo @JacquesOlivierLachaud

… named parameter (WIP)

…soc2022

.../include/CGAL/Polygon_mesh_processing/Curvatures/interpolated_corrected_curvature_measures.h

Polygon_mesh_processing/examples/Polygon_mesh_processing/interpolated_corrected_curvatures.cpp

.../include/CGAL/Polygon_mesh_processing/Curvatures/interpolated_corrected_curvature_measures.h

sloriot · 2022-07-18T07:25:22Z

/build:v0

github-actions · 2022-07-18T07:38:02Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6760/v0/Manual/index.html

will update docs to match void interpolated_corrected_measure_mesh( const PolygonMesh& pmesh, FaceMeasureMap fmm, const Measure_index mu_i, NamedParameters& np = parameters::default_values()) { later if it works

…soc2022

...gon_mesh_processing/include/CGAL/Polygon_mesh_processing/interpolated_corrected_curvatures.h

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt

afabri · 2023-11-07T08:16:45Z

~~A question that comes maybe a little bit late, but what is the relationship to the package Estimation of Local Differential Properties of Point-Sampled Surfaces~~ moved to #7859

github-actions · 2023-11-13T14:27:47Z

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

sloriot · 2023-11-13T17:36:38Z

The branch size went from 25MB to 1.1MB

sloriot · 2023-11-15T11:13:54Z

Successfully tested in CGAL-6.0-Ic-106

@sloriot

## Summary of Changes This PR introduces the possibility to chose a variable sizing field for isotropic remeshing. ## Release Management * Affected package(s): PMP * Feature/Small Feature (if any): [Here](https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Curvature-adaptive_remeshing) -- **pre-approval on 2023/10/24** * Link to compiled documentation (obligatory for small feature) [*wrong link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg) * License and copyright ownership: unchanged * Depends on #6760 ## TODO: - [x] check branch size (for @sloriot) - [x] handle the update of the interpolated curvature branch (for @sloriot)

hoskillua added 3 commits July 10, 2022 03:10

interpolated mu i measures (yet to check )

048d38d

I will replace ExactPredInexactConstructs with a geometry traits template next ISA

implemented computing mu_i over all faces

e63de4f

it works fine, still need to handle if vnm is not given

moved my main program to a new example file in PMP

2eeb88a

sloriot added gsoc gsoc-2022 Not yet approved The feature or pull-request has not yet been approved. Small feature Pkg::PMP CLA/CAA OK The contributor has signed a CLA or a CAA suitable for this contribution labels Jul 15, 2022

sloriot reviewed Jul 15, 2022

View reviewed changes

Triangulation_2/examples/Triangulation_2/triangulation_prog1.cpp Outdated Show resolved Hide resolved

hoskillua added 9 commits July 15, 2022 16:47

typo fix

5af7795

typo fix

8c943fd

added doc (yet to build), used generic GT instead of Epic, made VNM a…

4b0577a

… named parameter (WIP)

Merge remote-tracking branch 'cgal-dev/gsoc2022-ICC-hoskillua' into g…

34b816b

…soc2022

add documentation for enum

c3d654b

minor doc fix

e1961c4

added to reference manual page

138f1ea

doc typos

b1e1912

Merge remote-tracking branch 'cgal-dev/gsoc2022-ICC-hoskillua' into g…

dda3079

…soc2022

sloriot reviewed Jul 18, 2022

View reviewed changes

hoskillua and others added 7 commits July 18, 2022 16:17

used a face property map for computing measures, added license

a5f9969

will update docs to match void interpolated_corrected_measure_mesh( const PolygonMesh& pmesh, FaceMeasureMap fmm, const Measure_index mu_i, NamedParameters& np = parameters::default_values()) { later if it works

Merge remote-tracking branch 'cgal-dev/gsoc2022-ICC-hoskillua' into g…

528228f

…soc2022

add a couple of missing const and typename

a54033c

Updated Demo Display property plugin, added to license list,

5cc75c0

updated doc for interpolated_corrected_measure_mesh()

5af4a28

minor fix

8fea1a9

Merge remote-tracking branch 'upstream/master' into gsoc2022

2778d87

afabri reviewed Nov 2, 2023

View reviewed changes

...gon_mesh_processing/include/CGAL/Polygon_mesh_processing/interpolated_corrected_curvatures.h Outdated Show resolved Hide resolved

afabri reviewed Nov 2, 2023

View reviewed changes

...gon_mesh_processing/include/CGAL/Polygon_mesh_processing/interpolated_corrected_curvatures.h Outdated Show resolved Hide resolved

afabri reviewed Nov 2, 2023

View reviewed changes

...gon_mesh_processing/include/CGAL/Polygon_mesh_processing/interpolated_corrected_curvatures.h Show resolved Hide resolved

afabri reviewed Nov 2, 2023

View reviewed changes

...gon_mesh_processing/include/CGAL/Polygon_mesh_processing/interpolated_corrected_curvatures.h Show resolved Hide resolved

afabri reviewed Nov 7, 2023

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

MaelRL added the CHANGES.md not updated label Nov 8, 2023

sloriot added 2 commits November 13, 2023 15:18

fixes after review

4c315c1

remove TODO added in an issue

724c1f0

github-actions bot removed the Tested label Nov 13, 2023

update after rebase

c7be554

sloriot force-pushed the gsoc2022 branch from 025fab2 to c7be554 Compare November 13, 2023 17:35

sloriot added Accepted small feature and removed TODO pre-approved For pre-approved small features. After 15 days the feature will be accepted. labels Nov 13, 2023

update changes

8518e7d

sloriot added Under Testing and removed CHANGES.md not updated labels Nov 13, 2023

sloriot added Tested and removed Under Testing labels Nov 15, 2023

lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Nov 15, 2023

lrineau merged commit 69d9025 into CGAL:master Nov 15, 2023
1 check passed

lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Nov 15, 2023

sloriot pushed a commit to sloriot/cgal that referenced this pull request Nov 16, 2023

Merge PR CGAL#6760 into gsoc2023-adaptive_remesh-ipadjen

fe3fa38

sloriot pushed a commit to janetournois/cgal that referenced this pull request Nov 16, 2023

Merge PR CGAL#6760 into gsoc2023-adaptive_remesh-ipadjen

eb2a023

lrineau added the Merged_in_6.0 label Oct 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GSoC2022 - Interpolated Corrected Curvatures #6760

GSoC2022 - Interpolated Corrected Curvatures #6760

hoskillua commented Jul 15, 2022 •

edited by sloriot

Loading

sloriot commented Jul 15, 2022

sloriot commented Jul 18, 2022

github-actions bot commented Jul 18, 2022

afabri commented Nov 7, 2023 •

edited by sloriot

Loading

github-actions bot commented Nov 13, 2023

sloriot commented Nov 13, 2023

sloriot commented Nov 15, 2023

GSoC2022 - Interpolated Corrected Curvatures #6760

GSoC2022 - Interpolated Corrected Curvatures #6760

Conversation

hoskillua commented Jul 15, 2022 • edited by sloriot Loading

Release Management

TODOs:

sloriot commented Jul 15, 2022

sloriot commented Jul 18, 2022

github-actions bot commented Jul 18, 2022

afabri commented Nov 7, 2023 • edited by sloriot Loading

github-actions bot commented Nov 13, 2023

sloriot commented Nov 13, 2023

sloriot commented Nov 15, 2023

hoskillua commented Jul 15, 2022 •

edited by sloriot

Loading

afabri commented Nov 7, 2023 •

edited by sloriot

Loading