issue #7231 Improvement of layout of refines relations. #7236

albert-github · 2023-02-01T17:16:44Z

Implemented:

no extra "Refines" page
Refines on one line
Refines always in code style
2 arguments -> two arguments (for consistency)
added also the \qualifier

Implemented in Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h Results a.o.

doc_output/Kernel_23/classKernel_1_1CartesianConstIterator__2.html
doc_output/Kernel_23/classKernel_1_1BoundedSide__3.html

Note: due to the fact that this is a test implementation pages outside the scope of Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h might not be correct (in respect to code appearance of refines and multiple refines)

Implemented: - no extra "Refines" page - Refines on one line - Refines always in code style - `2 arguments` -> `two arguments` (for consistency - added also the `\qualifier` Implemented in Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h Results a.o. - doc_output/Kernel_23/classKernel_1_1Circle__2.html - doc_output/Kernel_23/classKernel_1_1BoundedSide__3.html Note: due to the fact that this is a test implementation pages outside the scope of Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h might not be correct (in respect to code appearance of refines and multiple refines)

Updating the 1.8.4 and 1.8.13 version as well

github-actions · 2023-02-02T09:37:52Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7236/v0/Manual/index.html

afabri · 2023-02-02T13:54:11Z

For me a title is a title, and it looks cluttered with the additional boxes.

albert-github · 2023-02-02T13:59:35Z

@afabri
Thank you for the valuable feedback, this can help in deciding what should be exactly done as it was written by @sloriot in #7231 (comment): "We should start by modifying one page, look at the output and agree on that change before applying it globally."

Hopefully more comments will follow so we can make a good decision soon (and apply it on other places as well).

MaelRL · 2023-02-02T20:45:59Z

I think the "Concept / Class Reference" near the actual concept / class name is just visual noise
I would remove the "AdaptableFunctor ..." box near "Class Reference", which doesn't add anything
The contrast between bold "refines" followed by colon and a one-line list, and then bold "see also" that does the exact opposite is not very nice.

Why not use the same the same presentation as "Inherits" (e.g. https://doc.cgal.org/latest/Triangulation_3/classCGAL_1_1Regular__triangulation__3.html)?

In fact, I would actually inherit concepts so all the requirements of a single concept would show on a single page, and you don't have to walk Periodic_3MeshTriangulation_3 > MeshTriangulationTraits_3 > RegularTriangulationTraits_3 > TriangulationTraits_3 > SpatialSortingTraits_3 to see if something is already documented somewhere in the stack.

albert-github · 2023-02-03T10:31:38Z

@MaelRL Thanks for the reaction.

I think the "Concept / Class Reference" near the actual concept / class name is just visual noise

I assume you mean here the "Class Reference" e.g. here:

The problem here is that this is automatically added by doxygen and won't be possible to remove
I would remove the "AdaptableFunctor ..." box near "Class Reference", which doesn't add anything

Supporting the comment of @afabri
The contrast between bold "refines" followed by colon and a one-line list, and then bold "see also" that does the exact opposite is not very nice.

There are her 2 items mentioned
- The layout of the "Refines". It is possible to make it like:
  
  This requires a small change in the ALIASES to e.g.:
```
"cgalRefines=<dl><dt><b>Refines</b>:</dt><dd></dd><dt></dt><dd>" \
"cgalRefines{1}=@qualifier \"\1\" ^^ @cgalRefines  @c \1.</dd></dl>" \
"cgalRefines{3}=@qualifier \"\1\" ^^ @qualifier \"\2\" ^^ @qualifier \"\3\" ^^ @cgalRefines @c \1, @c \2 and @c \3.</dd></dl>" \
```
- The "See also", I think this is also one of the possible candidates to be written on one line.
  - it is possible to do this with the current \sa like:
```
  \sa `CGAL::Iso_cuboid_3<Kernel>`, `CGAL::Sphere_3<Kernel>` and `CGAL::Tetrahedron_3<Kernel>`
```
    so we get:
    
    We can also make an ALIASES analogous the \cgalRefines... with name cgalSeeAlso though the problem with small problem with see also is that it can also refer to things like \ref (e.g. \sa Section \ref tds3cyclic) and \link ... \endlink so it has to be checked whether an "automatic" version is possible.
    As a side note: I see some inconsistent use where not all "class" names etc. (like in \sa CGAL::Exact_predicates_inexact_constructions_kernel) are embedded in back-ticks.
Why not use the same the same presentation as "Inherits"

I think this would take a bit a lot of place and one of the purposes is to reduce the the space required.
In fact, I would actually inherit concepts so all the requirements of a single concept would show on a single page, and you don't have to walk Periodic_3MeshTriangulation_3 > MeshTriangulationTraits_3 > RegularTriangulationTraits_3 > TriangulationTraits_3 > SpatialSortingTraits_3 to see if something is already documented somewhere in the stack.

Can you give a reference where this happens (page name) / give an example?

MaelRL · 2023-02-03T11:19:52Z

The problem here is that this is automatically added by doxygen and won't be possible to remove

That's a shame :)

I think this would take a bit a lot of place and one of the purposes is to reduce the the space required.

I'm not very sensible to this space argument: nobody is printing CGAL documentation and it becomes less readable on a single line. We already have "examples where this function/class appears" where it's on the same line, and I find it poor:

It will be the same if you put all "see also" and concepts with longer names on the same line.

Can you give a reference where this happens (page name) / give an example?

Do you mean a concept having many refinements? What I quoted is a real concept stack (https://doc.cgal.org/latest/Mesh_3/classMeshTriangulationTraits__3.html). If you meant, a page with refinement of concepts using inheritance, there is one here.

albert-github · 2023-02-03T11:40:48Z

place argument, this is a arbitrary and user dependent. It also has to do a great deal with readability and getting a quick overview.
the "examples" indeed it is hard to see where the one example ends and the next example starts (but also user dependent.
"concept stack", here we see indeed that there are quite a few "refines on refines"
MeshTriangulationTraits_3 > RegularTriangulationTraits_3 > TriangulationTraits_3 > SpatialSortingTraits_3
I think it would indeed be nice to have this line (with the links) at the different levels. Maybe also a "Refined by" would be nice.
I think though that this might be a bit out of scope for this issue / PR, but it is (in my opinion) certainly worthwhile to investigate whether or not these 2 things are possible.
(Note the page https://cgal.github.io/6849/v2/Isosurfacing_3/classIsosurfacingDomainWithGradient.html is in the 1.8.13 version a complete disaster, is there a corresponding page generated with the current master version?)

MaelRL · 2023-02-03T11:50:56Z

place argument, this is a arbitrary and user dependent. It also has to do a great deal with readability and getting a quick overview.

We are apparently OK with the place that the "inherits" Section takes on class pages, and that is a lot more space than the "Refines" takes.

I think it would indeed be nice to have this line (with the links) at the different levels. Maybe also a "Refined by" would be nice.

If you don't include the actual requirements on the page, you don't remove the fact that you need to click away and try to remember what you saw at previous concept levels. If you see look at https://doc.cgal.org/latest/Triangulation_3/classCGAL_1_1Regular__triangulation__3.html for example, it shows:

which is it's base's base. And it makes sense, because if we only showed CGAL::Triangulation_3 (the base), people would get annoyed that you have to click to CGAL::Triangulation_3 to see the functions of the base's base. Yet this is what we do for concepts.

I think it would indeed be nice to have this line (with the links) at the different levels. Maybe also a "Refined by" would be nice.

Sure, like for class inheritance :>

I think though that this might be a bit out of scope for this issue / PR, but it is (in my opinion) certainly worthwhile to investigate whether or not these 2 things are possible.

Seems relevant to me because I'm arguing that we could fully harmonize presentation of "refinement" and presentation of "inheritance".

(Note the page cgal.github.io/6849/v2/Isosurfacing_3/classIsosurfacingDomainWithGradient.html is in the 1.8.13 version a complete disaster, is there a corresponding page generated with the current master version?)

No, but it did not use any fancy trick: you just need to put an actual inheritance in the concept, and doxygen does the rest

class Concept
  : public ConceptBase
{ }

albert-github · 2023-02-03T12:02:42Z

Regarding the Note (and the mess in the 1.8.13 version), I'm not sure whether it is doxygen that creates the mess or that it is some postprocessing that is done by CGAL. Is there another place where this type of construct is used (Isosurfacing_3 is a new package and not in the "master" set present), I remember seeing it at other places as well but don't remember where.

albert-github · 2023-02-03T12:17:26Z

@MaelRL Looks like I found the "disaster" type of documentation again through #695. Problem looks like to be only present in /build/v... type of builds ...

albert-github · 2023-02-20T10:12:22Z

Are there any more comments / thoughts about this issue?

sloriot · 2023-03-13T16:18:05Z

So if I get it right, the conclusion is that people like the proposal except that we should not use \qualifier. Do you know if an official doxygen support for concept is in the work?

sloriot · 2023-03-13T16:31:52Z

I mean we want:

no extra "Refines" page
~~Refines on one line~~
Refines always in code style
2 arguments -> two arguments (for consistency)
~~added also the \qualifier~~

albert-github · 2023-03-14T09:43:27Z

Do you know if an official doxygen support for concept is in the work?

I never worked with concepts so I cannot really tell about the support and how it works, but in the doxygen 1.9.2 version there is the feature (see the doxygen changelog ):
issue #2732: Adding support for C++20 concepts (Origin: bugzilla #499352) [view], [view], [view]

Regarding the summary in #7236 (comment) I'm going to work on it (probably this or next week).

- Adjusted cgalRefines according to reviews - Implemented it in all files

albert-github · 2023-04-06T16:54:30Z

Any comments or plans for integration?

sloriot · 2023-04-06T17:29:38Z

I just missed that it was ready for testing. I'll test it in the next batch

Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_2--MakeCoprime_2.h

Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_1--MakeCoprime_1.h

Alpha_shapes_2/doc/Alpha_shapes_2/Concepts/AlphaShapeFace_2.h

Alpha_shapes_2/doc/Alpha_shapes_2/Concepts/WeightedAlphaShapeTraits_2.h

Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_1--MakeCoprime_1.h

Kernel_d/doc/Kernel_d/Concepts/Kernel--ConstructCartesianConstIterator_d.h

Kernel_d/doc/Kernel_d/Concepts/Kernel--Construct_max_vertex_d.h

Kernel_d/doc/Kernel_d/Concepts/Kernel--Construct_min_vertex_d.h

Number_types/doc/Number_types/Concepts/RootOf_2.h

Triangulation/doc/Triangulation/Concepts/TriangulationFullCell.h

albert-github · 2023-04-11T11:58:46Z

@sloriot Thanks for the review, I posted a number of questions before I start updating. Some of the suggested changes I have to look into.
I see that the 4 / 5 Adaptable functor problem already has been addressed, that is nice and quick. Thanks I can start updating.

albert-github · 2023-04-11T16:15:22Z

@sloriot

In Voronoi_diagram_2/doc/Voronoi_diagram_2/Concepts/AdaptationTraits_2.h I found:

A type for a functor that accesses the
site associated with a vertex. The functor should be a model of the
concepts `DefaultConstructible`, `CopyConstructible`,
`Assignable` and `AdaptableFunctor` (with one argument).

Should here also the `AdaptableFunctor` (with one argument) be replaced with `AdaptableUnaryFunction` ?

sloriot · 2023-04-11T16:18:23Z

@sloriot

In Voronoi_diagram_2/doc/Voronoi_diagram_2/Concepts/AdaptationTraits_2.h I found:
A type for a functor that accesses the
site associated with a vertex. The functor should be a model of the
concepts `DefaultConstructible`, `CopyConstructible`,
`Assignable` and `AdaptableFunctor` (with one argument).
Should here also the `AdaptableFunctor` (with one argument) be replaced with `AdaptableUnaryFunction` ?

Exactly

albert-github · 2023-04-11T17:56:56Z

Any suggestion for:

  \cgalRefines{AdaptableFunctor (with two or three arguments)}

as found in Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h

In the same file there are a number of occurences of:

\cgalRefines{AdaptableFunctor}

what to do wit these?

Furthermore there are the occurrences:

Algebraic_foundations/doc/Algebraic_foundations/Concepts/AlgebraicStructureTraits--DivMod.h:\cgalRefines{AdaptableFunctor}
Algebraic_foundations/doc/Algebraic_foundations/Concepts/AlgebraicStructureTraits--RootOf.h:\cgalRefines{AdaptableFunctor}
Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_1--ConstructAlgebraicReal_1.h:\cgalRefines{AdaptableFunctor}
Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_2--ConstructAlgebraicReal_2.h:\cgalRefines{AdaptableFunctor}
Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_2--Isolate_2.h:\cgalRefines{AdaptableFunctor}
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrTraits--CompareXOnBoundaryOfCurveEnd_2.h: * \cgalRefines{AdaptableFunctor}
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrTraits--CompareXOnBoundary_2.h: * \cgalRefines{AdaptableFunctor}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--ConstructPolynomial.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--EvaluateHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--IsZeroAt.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--IsZeroAtHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--Move.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--Permute.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--PseudoDivision.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--ScaleHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--SignAt.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--SignAtHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--Swap.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--TranslateHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}

How to handle these?

sloriot · 2023-04-12T06:00:34Z

Any suggestion for:

  \cgalRefines{AdaptableFunctor (with two or three arguments)}

as found in Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h

In the same file there are a number of occurences of:

\cgalRefines{AdaptableFunctor}

what to do wit these?

Furthermore there are the occurrences:

Algebraic_foundations/doc/Algebraic_foundations/Concepts/AlgebraicStructureTraits--DivMod.h:\cgalRefines{AdaptableFunctor}
Algebraic_foundations/doc/Algebraic_foundations/Concepts/AlgebraicStructureTraits--RootOf.h:\cgalRefines{AdaptableFunctor}
Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_1--ConstructAlgebraicReal_1.h:\cgalRefines{AdaptableFunctor}
Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_2--ConstructAlgebraicReal_2.h:\cgalRefines{AdaptableFunctor}
Algebraic_kernel_d/doc/Algebraic_kernel_d/Concepts/AlgebraicKernel_d_2--Isolate_2.h:\cgalRefines{AdaptableFunctor}
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrTraits--CompareXOnBoundaryOfCurveEnd_2.h: * \cgalRefines{AdaptableFunctor}
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrTraits--CompareXOnBoundary_2.h: * \cgalRefines{AdaptableFunctor}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--ConstructPolynomial.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--EvaluateHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--IsZeroAt.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--IsZeroAtHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--Move.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--Permute.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--PseudoDivision.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--ScaleHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--SignAt.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--SignAtHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--Swap.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}
Polynomial/doc/Polynomial/Concepts/PolynomialTraits_d--TranslateHomogeneous.h:\cgalRefines{AdaptableFunctor,CopyConstructible,DefaultConstructible}

How to handle these?

\cgalRefines{AdaptableBinaryFunctor, AdaptableTernaryFunctor}

afabri · 2023-04-12T06:10:50Z

Honestly when we leave AdaptableFunctor without unary, binary, etc this is ok and not a mistake. Especially if it has various combinations of arity.

Adjusted after review - usage of `Adaptable...Function` instead of `AdapatableFunctor (with... arguments)` - corrected some incorrect / superfluous `}`

albert-github · 2023-04-12T07:51:15Z

Corrected all mentions in the review above, ready for testing.

sloriot · 2023-04-16T20:17:02Z

Successfully tested in CGAL-5.6-Ic-223

albert-github mentioned this pull request Feb 1, 2023

Improvement of layout of refines relations. #7231

Closed

issue CGAL#7231 Improvement of layout of refines relations.

106e7d4

Updating the 1.8.4 and 1.8.13 version as well

This comment was marked as duplicate.

Sign in to view

MaelRL added Enhancement Doc labels Feb 2, 2023

albert-github mentioned this pull request Feb 3, 2023

Making description of author(s) of a package consistent #7238

Merged

MaelRL added the Under discussion label Feb 15, 2023

lrineau linked an issue Feb 20, 2023 that may be closed by this pull request

Improvement of layout of refines relations. #7231

Closed

albert-github marked this pull request as draft March 14, 2023 09:36

albert-github added 2 commits March 14, 2023 12:19

Merge branch 'master' into feature/issue_7231

19c97b0

issue CGAL#7231 Improvement of layout of refines relations.

2d60f46

- Adjusted cgalRefines according to reviews - Implemented it in all files

albert-github marked this pull request as ready for review March 14, 2023 16:38

sloriot modified the milestones: 5.6, 5.6-beta Apr 6, 2023

sloriot added the Batch_2 Second Batch of PRs under testing label Apr 7, 2023

sloriot reviewed Apr 11, 2023

View reviewed changes

add missing concepts

064a92e

issue CGAL#7231 Improvement of layout of refines relations.

b21b984

Adjusted after review - usage of `Adaptable...Function` instead of `AdapatableFunctor (with... arguments)` - corrected some incorrect / superfluous `}`

sloriot approved these changes Apr 12, 2023

View reviewed changes

sloriot added Under Testing and removed Batch_2 Second Batch of PRs under testing labels Apr 12, 2023

sloriot assigned lrineau Apr 16, 2023

sloriot added Tested and removed Under discussion Ready to be tested Under Testing labels Apr 16, 2023

lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 17, 2023

lrineau merged commit 824976a into CGAL:master Apr 17, 2023

lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 17, 2023

lrineau deleted the feature/issue_7231 branch April 17, 2023 08:28

albert-github mentioned this pull request Apr 18, 2023

Improvement of layout of model relations. #7395

Closed

lrineau added the Merged_in_5.6-beta1 label Jun 22, 2023

lrineau added the Merged_in_5.6 label Jul 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

issue #7231 Improvement of layout of refines relations. #7236

issue #7231 Improvement of layout of refines relations. #7236

albert-github commented Feb 1, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

github-actions bot commented Feb 2, 2023

afabri commented Feb 2, 2023

albert-github commented Feb 2, 2023

MaelRL commented Feb 2, 2023

albert-github commented Feb 3, 2023

MaelRL commented Feb 3, 2023 •

edited

Loading

albert-github commented Feb 3, 2023 •

edited

Loading

MaelRL commented Feb 3, 2023

albert-github commented Feb 3, 2023 •

edited

Loading

albert-github commented Feb 3, 2023

albert-github commented Feb 20, 2023

sloriot commented Mar 13, 2023

sloriot commented Mar 13, 2023

albert-github commented Mar 14, 2023

albert-github commented Apr 6, 2023

sloriot commented Apr 6, 2023

albert-github commented Apr 11, 2023

albert-github commented Apr 11, 2023

sloriot commented Apr 11, 2023

albert-github commented Apr 11, 2023

sloriot commented Apr 12, 2023

afabri commented Apr 12, 2023

albert-github commented Apr 12, 2023

sloriot commented Apr 16, 2023

issue #7231 Improvement of layout of refines relations. #7236

issue #7231 Improvement of layout of refines relations. #7236

Conversation

albert-github commented Feb 1, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

github-actions bot commented Feb 2, 2023

afabri commented Feb 2, 2023

albert-github commented Feb 2, 2023

MaelRL commented Feb 2, 2023

albert-github commented Feb 3, 2023

MaelRL commented Feb 3, 2023 • edited Loading

albert-github commented Feb 3, 2023 • edited Loading

MaelRL commented Feb 3, 2023

albert-github commented Feb 3, 2023 • edited Loading

albert-github commented Feb 3, 2023

albert-github commented Feb 20, 2023

sloriot commented Mar 13, 2023

sloriot commented Mar 13, 2023

albert-github commented Mar 14, 2023

albert-github commented Apr 6, 2023

sloriot commented Apr 6, 2023

albert-github commented Apr 11, 2023

albert-github commented Apr 11, 2023

sloriot commented Apr 11, 2023

albert-github commented Apr 11, 2023

sloriot commented Apr 12, 2023

afabri commented Apr 12, 2023

albert-github commented Apr 12, 2023

sloriot commented Apr 16, 2023

MaelRL commented Feb 3, 2023 •

edited

Loading

albert-github commented Feb 3, 2023 •

edited

Loading

albert-github commented Feb 3, 2023 •

edited

Loading