Replace boost by std #7403
Merged
Replace boost by std #7403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boost's version is working on std::pair but we decided to no longer consider iterator pairs as ranges
boost::is_float
sloriot
added
Under Testing
and removed
Batch_2
sloriot
added a commit
to sloriot/cgal
that referenced
this pull request
Jun 22, 2023
Replace boost by std
sloriot
force-pushed
the
CGAL-replace_boost_by_std
branch
from
b36bf0a
to
e80e05b
Compare
sloriot
force-pushed
the
CGAL-replace_boost_by_std
branch
from
e80e05b
to
dfc386d
Compare
lrineau
reviewed
Jun 26, 2023
| @@ -154,11 +155,11 @@ class Polyline_simplification_2 | |||
| (*it)->set_removable(false); | |||
| ++it; | |||
| for(; it != ite; ++it){ | |||
| if((std::next(it) != ite) && (std::prev(it)== std::next(it))){ | |||
| if((boost::next(it) != ite) && (boost::prior(it)==boost::prior(it))){ | |||
There was a problem hiding this comment.
Any idea why the behavior is different?
There was a problem hiding this comment.
The iterator implementation is most probably buggy (some platforms complains that it is not bidirectional and there are infinite loops on other platforms).
…stacking boost::iterator_adaptor also restore std::prev
sloriot
added
Batch_1
20 tasks
sloriot
added
Tested
and removed
Under Testing
Batch_1
|
Successfully tested in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Replace features in boost by features introduces in c++11/c++14