Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offset Meshing Plugin Improvements #7508

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Offset Meshing Plugin Improvements #7508

merged 3 commits into from
Jun 16, 2023

Conversation

MaelRL
Copy link
Member

@MaelRL MaelRL commented Jun 9, 2023 •
edited
Loading

Summary of Changes

  • fixed broken formula for surface mesh and polygon soup items creating inverted meshes and sometimes triggering Mesh_3 assertions
  • fixed not even actually working for polygon soups...
  • fixed applicable() allowing wrong item combinations
  • fixed a few crashes (like crashing for non-triangulated inputs)
  • fixed some memory leaks
  • fixed UI file names (used PMP::iso_remeshing names)
  • fixed inflate() needlessly normalizing already normalized normals
  • removed useless sqrts in offset meshing implicit function: we just need a label, we don't care about the actual distance
  • avoid recomputing bbox way too many times
  • cleaned UI
  • some more stuff

Release Management

  • Affected package(s): Polyhedron
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): n/a
  • License and copyright ownership: no change

@MaelRL
Fix function name
9fbfd93
@MaelRL
Do not proceed if user cancels
f85b839
@MaelRL
Update offset meshing plugin
efd68a5 
- fixed not working for polygon soups
- fixed broken formula for both giving Mesh_3 assertions and inverted meshes
- fixed applicable() allowing wrong combinations
- fixed inflate() needlessly normalizing normals
- fixed crashing for non triangulated inputs
- fixed some memory leaks
- fixed dialog name
- removed useless sqrts
- avoid recomputing bbox 4 times
- cleaned UI
- etc.
@MaelRL MaelRL added this to the 6.0-beta milestone Jun 9, 2023
@MaelRL MaelRL changed the title Offset Meshin Plugin Improvements Offset Meshing Plugin Improvements Jun 9, 2023
@sloriot
Copy link
Member

sloriot commented Jun 14, 2023

Successfully tested in CGAL-6.0-Ic-1

@lrineau lrineau self-assigned this Jun 15, 2023
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 15, 2023
@lrineau lrineau merged commit e60e7b8 into CGAL:master Jun 16, 2023
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lrineau lrineau

Labels
Bug Cleaning Enhancement Merged_in_6.0 Pkg::Polyhedron Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@MaelRL @sloriot @lrineau