Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon repair #7608

Merged
merged 188 commits into from
Mar 22, 2024
Merged

Polygon repair #7608

merged 188 commits into from
Mar 22, 2024

Conversation

kenohori
Copy link
Member

@kenohori kenohori commented Jul 19, 2023

Summary of Changes

New Polygon_repair package, which is under development for GSoC 2023. It includes:

  • The main Polygon_repair class with functions to repair Polygon_2, Polygon_with_holes_2 and Multipolygon_with_holes_2.
  • Underlying classes to build a constrained triangulation with odd-even counting of constraints and to store the necessary repair info in every face.
  • Validation functions for Polygon_2, Polygon_with_holes_2 and Multipolygon_with_holes_2 (not comprehensive)
    As well as some additions to the Polygon package:
  • Concept and class to represent multipolygons with holes (Multipolygon_with_holes_2)
  • Specialisation of CGAL::draw for multipolygons with holes.

Release Management

@sloriot sloriot added gsoc gsoc-2023 Not yet approved The feature or pull-request has not yet been approved. Small feature TODO labels Jul 20, 2023
@sloriot sloriot added Batch_1 First Batch of PRs under testing Tested and removed Under Testing Ready to be tested Batch_1 First Batch of PRs under testing labels Mar 20, 2024
@sloriot
Copy link
Member

sloriot commented Mar 21, 2024

Successfully tested in 6.0-Ic-197

@lrineau lrineau added Accepted feature and removed pre-approved For pre-approved small features. After 15 days the feature will be accepted. labels Mar 21, 2024
@lrineau
Copy link
Member

lrineau commented Mar 21, 2024

@sloriot You added TODO , two weeks ago. Is there still something to do? The feature itself is accepted.

@sloriot sloriot force-pushed the gsoc2023-polygon_repair-kenohori branch from 813bb2d to 151b343 Compare March 21, 2024 14:30
@github-actions github-actions bot removed the Tested label Mar 21, 2024
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot added Tested and removed TODO labels Mar 21, 2024
@sloriot
Copy link
Member

sloriot commented Mar 21, 2024

I reduced the size, you can merge it now (git diff kenohori/gsoc2023-polygon_repair-kenohori..HEAD was empty)

@lrineau lrineau self-assigned this Mar 21, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Mar 21, 2024
@github-actions github-actions bot removed the Tested label Mar 21, 2024
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@lrineau lrineau added the Tested label Mar 21, 2024
@lrineau lrineau merged commit 8212284 into CGAL:master Mar 22, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Mar 22, 2024
@MaelRL
Copy link
Member

MaelRL commented Mar 25, 2024

Will there be a news entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants