Polyhedron demo - Use subdomain's color only when meshing from labeled images #7800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lrineau
added
the
presentation
lrineau
added a commit
to lrineau/cgal
that referenced
this pull request
Oct 16, 2023
…e_patch_index-color Polyhedron demo - Use subdomain's color only when meshing from labeled images # Conflicts: # Polyhedron/demo/Polyhedron/Scene_triangulation_3_item.cpp
Domains colors better follow item color
sloriot
added
Batch_1
|
Successfully tested in CGAL-6.0-Ic-96 |
lrineau
added
the
rm only: ready for master
lrineau
removed
rm only: ready for master
lrineau
reviewed
Jan 11, 2024
Comment on lines
+889
to
+897
| double i = -1; | ||
| double patch_hsv_value = use_subdomain_colors ? fmod(c.valueF() + .5, 1.) : c.valueF(); | ||
| for (Indices::iterator it = surface_patch_indices_.begin(), | ||
| end = surface_patch_indices_.end(); it != end; ++it, i += 1.) | ||
| { | ||
| double hue = c.hueF() + 1. / double(nb_patch_indices) * i; | ||
| if (hue > 1) { hue -= 1.; } | ||
| colors[*it] = QColor::fromHsvF(hue, c.saturationF(), patch_hsv_value); | ||
| } |
There was a problem hiding this comment.
@ange-clement I have an issue with the demo, and it is caused by this old PR (merged Nov 6 2023).
I think the issue is with this loop (and the next one, that is similar).
Let's suppose nb_patch_indices==1. At the first iteration of the loop, i is equal to -1, and the expression
c.hueF() + 1. / double(nb_patch_indices) * iis equal to
c.hueF() - 1.and then is almost certainly an invalid hue (the only valid negative hue is -1.f, for achromatic colors).
Why start i at -1 instead of 0 like it was before?
There was a problem hiding this comment.
What is more, but that is not directly related to your PR, hue should be in float instead of double.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes issue #7799 : Surface_patch_index are not colored anymore.
Now, Surface_patch_index are colored by default.
But when meshing from labelled images, the subdomain colors are used.
Release Management