Triangulation_3 - add vertices() helper functions
#7808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7808/v0/Manual/index.html |
|
/force-build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7808/v0/Manual/index.html |
janetournois
added
Small feature
Not yet approved
|
Note that in the 2D case for faces we have |
|
/build:v1 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7808/v1/Manual/index.html |
lrineau
added
pre-approved
|
/build:v2 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7808/v2/Manual/index.html |
sloriot
added
Batch_1
lrineau
added
Accepted small feature
and removed
pre-approved
|
Successfully tested in CGAL-6.0-Ic-106 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR introduces new helper functions in
Triangulation_3, that returns astd::array<Vertex_handle, dim_of_the_simplex>for each type of simplex (vertex, edge, facet, cell).Iterating over the vertices of a simplex is implemented quite a few times in
Tetrahedral_remeshingfor example, and these helper functions would help the readability of the code (and also avoid mistakes).Release Management