Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh_3::Add handling of *.nii files in one example #7823

Merged
merged 3 commits into from
May 26, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Oct 24, 2023

Summary of Changes

While the Polyhedron demo can read *.nii files there is no example in examples/Mesh_3/.
This PR adds the functionality to the example that uses vtk to read DICOM data.

This is triggered by this question on stackoverflow.

  • Support of *.nrrd format
  • example for segmented images
  • Add example data for the file formats.

Release Management

  • Affected package(s): Mesh_3
  • License and copyright ownership: unchanged

@sloriot sloriot added Batch_1 First Batch of PRs under testing Under Testing and removed Batch_1 First Batch of PRs under testing labels Oct 24, 2023
@sloriot
Copy link
Member

sloriot commented Nov 2, 2023

Successfully tested in CGAL-6.0-Ic-96

@lrineau
Copy link
Member

lrineau commented Nov 2, 2023

@afabri This PR still have several TODO items. Should I wait or merge it?

@lrineau lrineau added the TODO label Nov 2, 2023
@afabri
Copy link
Member Author

afabri commented Nov 2, 2023

@afabri This PR still have several TODO items. Should I wait or merge it?

Wait.

@sloriot
Copy link
Member

sloriot commented Jan 24, 2024

@afabri, this PR was marked tested 3 month ago and is still waiting for some TODOs. Maybe you want to open an issue instead and integrate the PR.

Updated example to work with a default dataset.
@github-actions github-actions bot removed the Tested label Apr 12, 2024
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot added Under Testing Batch_1 First Batch of PRs under testing and removed Batch_1 First Batch of PRs under testing labels May 21, 2024
@sloriot
Copy link
Member

sloriot commented May 26, 2024

Successfully tested in 6.0-Ic-251

@sloriot sloriot merged commit afe7f90 into CGAL:master May 26, 2024
9 checks passed
@sloriot sloriot deleted the Mesh_3-read_nii-GF branch May 26, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants