CGAL Lab: Rendering polygons with ghost edges #7898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_in_triangulation
ghost edges are not added to cdt in FacetTriangulator mark_domain_in_triangulation is used to mark holes as external
sloriot
reviewed
Nov 30, 2023
sloriot
reviewed
Nov 30, 2023
bugfixes
sloriot
added
Batch_2
sloriot
reviewed
Jan 4, 2024
sloriot
added
the
Not yet approved
|
Successfully tested in CGAL-6.0-Ic-147 |
|
@sloriot You marked with
Not yet approved
|
I wasn't sure if somebody should review it |
|
I did a quick review + testing the behavior on non triangle faces and it works as before. You can merge it. |
sloriot
removed
the
Not yet approved
soesau
added a commit
to soesau/cgal
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polygons and meshes with non-triangular faces that have ghost edges, i.e., holes connected via two identical edges to the outer border of the polygon, are now correctly rendered.
The FacetTriangulator now uses mark_domain_in_triangulation to set is_external property.
Release Management