Tetrahedral remeshing - deal with c3t3 complex edges #7909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build:v0 |
|
There was an error while building the doc: |
|
/force-build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7909/v0/Manual/index.html |
| @@ -103,6 +103,12 @@ setting the named parameter `remesh_boundaries` to `false`. | |||
|
|
|||
| \cgalExample{Tetrahedral_remeshing/tetrahedral_remeshing_with_features.cpp } | |||
|
|
|||
| It is also possible to define the polyline features as the ones | |||
| stored as complex edges in a `Mesh_complex_3_in_triangulation_3` | |||
| (e.g. generated by the \ref PkgMesh3 package mesh generation algorithms). | |||
There was a problem hiding this comment.
Line should be:
(e.g. generated by the \ref PkgMesh3 "package mesh generation algorithms").
note the double quotes
There was a problem hiding this comment.
@janetournois This discussion is still left unsolved. And it seems Albert it right. The result in a local doc compilation is the following:
(I will convert this comment to a issue afterward.)
far points inserted by concurrent Mesh_3
|
Errors in the testsuite |
sloriot
added
Batch_1
error on windows testsuites : "The fully qualified file name must be less than 260 characters."
sloriot
added
Under Testing
Tested
and removed
Ready to be tested
Under Testing
Batch_1
|
Successfully tested in CGAL-6.0-Ic-129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
For a mesh generated by Mesh_3, that has complex edges that do not lie at the intersection of surface patches, automatic detection of these features is impossible from the input triangulation.
This PR introduces a new named parameter
edge_is_constrained_maptoconvert_to_triangulation_3()that sets the edges constrained status corresponding to theiris_in_complex()status.This pmap can then be used straight away in
tetrahedral_isotropic_remeshing().Release Management