Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triangulation_2: Make IO save by changing file names #7957

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Triangulation_2: Make IO save by changing file names #7957

merged 3 commits into from
Jan 19, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Jan 2, 2024

Summary of Changes

Change file names to avoid interaction between test cases.

@MaelRL I noticed that the RT test does not read back.

Release Management

  • Affected package(s): Triangulation_2
  • Issue(s) solved (if any): fix testsuite
  • License and copyright ownership: unchanged

@afabri afabri added this to the 6.0-beta milestone Jan 2, 2024
@afabri afabri requested a review from MaelRL January 2, 2024 17:00
@afabri afabri self-assigned this Jan 2, 2024
@sloriot sloriot added Batch_2 Second Batch of PRs under testing Under Testing and removed Batch_2 Second Batch of PRs under testing labels Jan 3, 2024
@sloriot
Copy link
Member

sloriot commented Jan 19, 2024

Successfully tested in CGAL-6.0-Ic-154 (and earlier testsuites)

@sloriot sloriot merged commit 722e382 into CGAL:master Jan 19, 2024
9 checks passed
@sloriot sloriot deleted the BGL-concurrentIO-GF branch January 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaelRL MaelRL Awaiting requested review from MaelRL

Assignees

@afabri afabri

Labels
Merged_in_6.0 Pkg::Triangulation_2 Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@afabri @sloriot @lrineau