-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Use Expr::is_zero() of AST #8002
Conversation
Is this implementation of Is_one really faster? From what I can see, doubleInterval itself should already be more costly than |
When comparing to 1 that constructs an |
Co-authored-by: Marc Glisse <[email protected]>
Co-authored-by: Marc Glisse <[email protected]>
cgal/CGAL_Core/include/CGAL/CORE/Expr_impl.h Lines 84 to 89 in 96f698c
Looks like cgal/CGAL_Core/include/CGAL/CORE/Expr.h Lines 252 to 253 in 96f698c
IIUC (but I know little about CORE) it stores an approximate value as a |
Successfully tested in CGA-6.0-Ic-173 |
This pull-request was previously marked with the label |
For the time being let's reduce it to the initial scope, namely to have a faster test for being zero. |
Successfully tested in CGAL-6.0-Ic-192 |
Summary of Changes
Accelerate comparison with zero
Release Management