Change inclusion order to check dependencies #8010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloriot
reviewed
Feb 15, 2024
Polygon_mesh_processing/examples/Polygon_mesh_processing/corefinement_parallel_union_meshes.cpp
Show resolved
Hide resolved
|
Successfully tested in CGAL-6.0-Ic-176 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Issue #8009 revealed that some header files do not
#includeall what they need. We do not see that in the testsuite, as we "usually" first include a kernel and then only header files of higher level functions. This PR includes the high level first and then only a kernel. We start with the Polygon Mesh Processing package, but will extend this to the other packages.This PR should fix the reported issue, but changes in the testsuite itself should reveal other similar issues.
Release Management
Affected package(s): PMP
Issue(s) solved (if any): tbd No matching function for call to
midpoint(const Point_3&, const Point_3&)onbounded_error_Hausdorff_distance#8009License and copyright ownership: unchanged.