Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGAL Lab #8099

Merged
merged 5 commits into from
Apr 16, 2024
Merged

CGAL Lab #8099

merged 5 commits into from
Apr 16, 2024

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Mar 26, 2024 •
edited
Loading

Summary of Changes

Implement the renaming from Polyhedron Demo to CGAL Lab.

Release Management

  • Affected package(s): Polyhedron/demo, Three
  • License and copyright ownership: unchanged

@lrineau lrineau added this to the 6.0-beta milestone Mar 26, 2024
@lrineau
Copy link
Member Author

lrineau commented Mar 26, 2024

/build:CGALLab-v0

@github-actions GitHub Actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8099/CGALLab/Manual/index.html

@afabri
Copy link
Member

afabri commented Apr 2, 2024 

CGAL-6.0-Ic-208\test\Lab_Demo\Mesh_3.cpp(1,10): fatal  error C1083: Cannot open include file: 'CGAL_Lab.h': No such file or directory 
````     in this [testsuite](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-208/Lab_Demo/TestReport_Christo_MSVC-2022-Community-Release.gz)

@sloriot sloriot added Batch_1 First Batch of PRs under testing Under Testing and removed Under Testing Batch_1 First Batch of PRs under testing labels Apr 4, 2024
@sloriot
Copy link
Member

sloriot commented Apr 15, 2024

Successfully tested in CGAL-6.0-Ic-217

@lrineau lrineau self-assigned this Apr 16, 2024
@lrineau lrineau merged commit eb07187 into CGAL:master Apr 16, 2024
8 of 9 checks passed
@lrineau lrineau deleted the CGAL_Lab branch April 16, 2024 09:13
@lrineau lrineau mentioned this pull request Apr 18, 2024
Merged
lrineau referenced this pull request May 17, 2024
@sloriot
fix link error
b9ee8c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lrineau lrineau

Labels
CGAL 3D demo dev-meeting Merged_in_6.0 Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@lrineau @afabri @sloriot