-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMP::isotropic_remeshing() - add NP allow move functor
#8150
PMP::isotropic_remeshing() - add NP allow move functor
#8150
Conversation
this NP exists in tangential_relaxation() and we want to be able to use it in the relaxation step, from the named parameters of isotropic_remeshing()
b32982c
to
96d8e1a
Compare
To solve #8134, we can think of a smart functor that would prevent self-intersections from being introduced by the relaxation step |
Successfully tested in CGAL-6.0-Ic-235 |
Should we close the issue #8134, how that this PR is merged, or leave it open? Because it seems the actual solution to #8134 is
|
I will post a possible functor in the issue soon! |
* \cgalParamNBegin{allow_move_functor} | ||
* \cgalParamDescription{A function object used to determinate if a vertex move should | ||
* be allowed or not during the relaxation step.} | ||
* \cgalParamType{Unary functor that provides `bool operator()(vertex_descriptor v, Point_3 src, Point_3 tgt)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the sentence itself contradicts the word "Unary" (that would take one parameter). That is not a unary functor.
Oops
Summary of Changes
The function
tangential_relaxation()
has a named parameter calledallow_move_functor
that enables the user to prevent and cancel some vertex moves.With this PR, it is now possible to use the same parameter for the relaxation steps of
CGAL::Polygon_mesh_processing::isotropic_remeshing()
Release Management