Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CC selection in selection item #8238

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Conversation

MaelRL
Copy link
Member

@MaelRL MaelRL commented May 29, 2024

Summary

And remove CC selection from the deformation item, where it had limited use.

Release Management

  • Affected package(s): Lab
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): -
  • License and copyright ownership: no change

@MaelRL MaelRL added this to the 6.1-beta milestone May 29, 2024
@sloriot
Copy link
Member

sloriot commented May 29, 2024

Works as expected, thanks! One remark: Components is now the default tab, it should be Simplices IMO

@afabri
Copy link
Member

afabri commented May 29, 2024

Works as expected, thanks! One remark: Components is now the default tab, it should be Simplices IMO

And in Simplices it should be faces (statistically for me).

@MaelRL
Copy link
Member Author

MaelRL commented May 29, 2024

Works as expected, thanks! One remark: Components is now the default tab, it should be Simplices IMO

And in Simplices it should be faces (statistically for me).

There are a lot of instances of "facet(s)", so I leave it out of scope of this PR.

@sloriot
Copy link
Member

sloriot commented May 29, 2024

Works as expected, thanks! One remark: Components is now the default tab, it should be Simplices IMO

And in Simplices it should be faces (statistically for me).

There are a lot of instances of "facet(s)", so I leave it out of scope of this PR.

I guess Andreas meant putting face(t)s as default selected simplex instead of vertex

@MaelRL
Copy link
Member Author

MaelRL commented May 29, 2024

The plugin uses everywhere the combo box ID (aka the position of "Facet" or "Vertex" in the list of options) so it's a lot more work than just changing the order in the UI. Not worth it right now.

@afabri
Copy link
Member

afabri commented May 29, 2024

Works as expected, thanks! One remark: Components is now the default tab, it should be Simplices IMO

And in Simplices it should be faces (statistically for me).

There are a lot of instances of "facet(s)", so I leave it out of scope of this PR.

I guess Andreas meant putting face(t)s as default selected simplex instead of vertex

right. Most of the time I select regions. What do you select the most often in practice?

@sloriot
Copy link
Member

sloriot commented Jun 3, 2024

Successfully tested in CGAL-6.0-Ic-257

@afabri
Copy link
Member

afabri commented Jun 3, 2024

Successfully tested in CGAL-6.0-Ic-257

Do we have to test it in the GUI on a Windows machine?

@MaelRL
Copy link
Member Author

MaelRL commented Jun 3, 2024

Successfully tested in CGAL-6.0-Ic-257

Do we have to test it in the GUI on a Windows machine?

Can't hurt, both for the buttons that i have reorganized and so you can check the behavior of the CC buttons since you had the issue.

Note that I left a behavior that a bit is surprising at first but makes sense : when you click "select CCs with simplices count under threshold", it updates the threshold to a new value. That new value is the number of simplices for the next smallest, unselected CC. Thus, you keep clicking and it adds one CC at the time.

@lrineau lrineau modified the milestones: 6.1-beta, 6.0-beta Jun 3, 2024
@lrineau lrineau self-assigned this Jun 3, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 3, 2024
@lrineau lrineau merged commit 2c13f1f into CGAL:master Jun 3, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 3, 2024
@lrineau lrineau deleted the Lab-Fix_components-GF branch June 3, 2024 15:59
@lrineau
Copy link
Member

lrineau commented Jun 3, 2024

Successfully tested in CGAL-6.0-Ic-257

Do we have to test it in the GUI on a Windows machine?

I have actually merged the pull-request. Now the GUI can be tester from a build of CGAL Lab from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants