Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt for recent VTK to fix CMake Warning #8279

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

janetournois
Copy link
Member

Summary of Changes

Versions >= 9 of VTK trigger the following CMake warning using CGAL's CMakeLists

CMake Deprecation Warning at C:/dev/VTK-9.2.2/build/lib/cmake/vtk-9.2/vtk-use-file-deprecated.cmake:1 (message):
  The `VTK_USE_FILE` is no longer used starting with 8.90.
Call Stack (most recent call first):
  CMakeLists.txt:32 (include)

I suggest this modification of the CMakeLists of Mesh_3 examples, that also requires moving to VTK 9 (9.0 was released in 2020).
If this modification and new requirement are validated, I can apply the change everywhere.

Release Management

  • Affected package(s): Mesh_3 for now
  • License and copyright ownership: unchanged

@lrineau lrineau added the rm: not for next release Indicate to the release team that a PR should not be merged before the next release branch is forked label Jun 11, 2024
@sloriot
Copy link
Member

sloriot commented Jun 12, 2024

Successfully tested in CGAL-6.0-Ic-265

@sloriot sloriot added this to the 6.0 milestone Jul 23, 2024
@sloriot sloriot removed the rm: not for next release Indicate to the release team that a PR should not be merged before the next release branch is forked label Aug 14, 2024
@sloriot sloriot merged commit 862a3b6 into CGAL:master Aug 19, 2024
9 checks passed
@sloriot sloriot deleted the CMake-update_find_vtk-jtournois branch August 19, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants