Pasto in TDS #8349
Merged
Pasto in TDS #8349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Marc! |
sloriot
force-pushed
the
Triangulation-pasto-glisse
branch
from
7f1fdcd
to
256d656
Compare
|
Successfully tested in CGAL-6.0-Ic-289 |
|
This pull-request was previously marked with the label |
|
Successfully tested in CGAL-6.0-Ic-291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Apply the operation to both cells, instead of twice to the same.
I did not try to understand everything the function does, and I did not test beyond checking that the example in the issue and the tests in test/Triangulation run. Ideally we would improve the tests (both
is_validand the filestest/Triangulation/*.cpp), but that's not in my priorities right now.Feel free to rebase against whatever release branch you want.
Release Management