-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 알림 api 연결 및 4차 컴포넌트 UI 구현 #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4차 컴포넌트 구현하시느라 수고 많으셨어요!!!!!🙌
코멘트 남긴 부분 수정 부탁드립니다아 🙇♀️🙇♀️🙇♀️
export const textStyle = css({ | ||
color: color.BK, | ||
'::placeholder': { | ||
color: color.GY[1], | ||
}, | ||
height: '17px', | ||
minWidth: '627px', | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
타이포 속성이 누락된 것 같아요!! 추가 부탁드려용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정해두도록 하겠습니다~!
interface NoResultsMessageProps { | ||
keyword: string; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
톡픽 검색, 밸런스게임 검색, 전체 검색일 때마다 보여지는 텍스트가 달라서 해당 관련 props 추가해야 할 것 같습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추가로 코멘트 드리면, 메시지를 상수화 하고, 케이스 별로 호출하는 방식도 괜찮아보이네요 : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다✅
selectedButton={selectedButton} | ||
onClick={handleButtonClick} | ||
/> | ||
<div css={S.letterStyle}>VS</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스토리북 확인해보니 VS 텍스트 위치 조정이 필요할 것 같습니당 수정 부탁드려요!!
|
||
const TitleDescriptionField = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스토리북에서 해당 컴포넌트 input에 입력이 안되는 것 같아요 확인 부탁드립니다 🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4차 UI 구현 고생 많으셨어요!!
스토리북 관련 이슈는 아름님이 대부분 짚어주신 거같네요 :)
추가로 코멘트 드린 부분들 확인 한 번 부탁드립니다! 다시 한번 고생 많으셨습니다 🚀
@@ -25,6 +25,7 @@ | |||
"@tanstack/react-query-devtools": "^5.20.2", | |||
"axios": "^1.6.7", | |||
"dayjs": "^1.11.10", | |||
"event-source-polyfill": "^1.0.31", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 패키지는 SSE 쪽 에러 핸들링을 위해 설치한것인지 궁금합니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 이 패키지는 SSE에 헤더를 넣을 때 필요한 패키지라 설치하였습니다!
<li>단어의 철자가 정확한지 확인해 보세요.</li> | ||
<li>검색 옵션을 변경해 다시 검색해 보세요.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 상수화 해도 될 거 같습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다✅
interface NoResultsMessageProps { | ||
keyword: string; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추가로 코멘트 드리면, 메시지를 상수화 하고, 케이스 별로 호출하는 방식도 괜찮아보이네요 : )
/* eslint-disable jsx-a11y/no-static-element-interactions */ | ||
/* eslint-disable @typescript-eslint/no-unsafe-assignment */ | ||
/* eslint-disable @typescript-eslint/no-unsafe-argument */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
태그 속성관련 이슈같은데 해당 lint 에러의 경우
const optionB = values[1]; | ||
|
||
return ( | ||
<div css={S.containerStyle}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
선택 시 container 전체적인 움직임이 있는거 같아요! flex 속성이나 block 관련 옵션을 추가해주시면 좋을 거 같습니다 !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이부분 좀 더 자세히 피드백을 주실 수 있을까요..?😅 수정해보려고 하는데 block을 사용해도 잘안되네요🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
답변이 늦었네요!! 죄송합니다 😢
BalanceGameBox 또는 BalanceGameButton 의 최상단 container에 대해서 boxSizing: 'border-box'
를 적용시키는것이 어떨까 하는 코멘트 였습니다!
block은 제가 잘못 기재했네요!! 혼동 드려 죄송합니닷!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스토리 북에 action 시 좌,우 아이템 hover 시 밀림 현상
이 있더라구요! 해당 문제에 대한 해결 방안 이었습니다..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 사항 확인했습니다 수고 많으셨어요!!! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 사항 확인 완료입니다!! 스토리북에서도 화면 비율을 줄여도 같은 비율로 잘 적용되네요! 고생 하셨습니다 :)
flexDirection: 'row', | ||
alignItems: 'center', | ||
position: 'relative', | ||
width: '1122px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아주 잘 적용됩니다!! 🚀🚀🚀
💡 작업 내용
💡 자세한 설명
✅ Notification
현재 알림 api를 구현은 해두었으나, 오류가 존재해 미해결인 상태입니다.
추후 에러 해결에 대한 이슈를 파 합칠 예정입니다.
✅ BalanceGameButton, SubTag, TitleDescriptionField
✅ BalanceGameBox
BalanceGameButton
으로 전체 버튼들을 합치려고 하였으나, 이전에 투표 버튼과 비슷하기도 하고, 버튼 사이에 존재하는VS
때문에 왼쪽, 오른쪽을 공통된 atom 컴포넌트로 보고 분리하였습니다.values
배열을 넣어두었고, [0]은 왼쪽, [1]은 오른쪽 버튼의 값을 포함하고 있다고 가정하였습니다.✅ NoResultsMessage
📗 참고 자료 (선택)
📢 리뷰 요구 사항 (선택)
🚩 후속 작업 (선택)
✅ 셀프 체크리스트
closes #182