clean up evp kernel 2 implementation #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclare108213
approved these changes
May 31, 2019
|
@apcraig and @eclare108213 : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up EVP kernel=2 implementation, addresses some of the issues in #279
-- renamed namelist evp_kernel_ver to kevp_kernel
-- cleaned up ice_dyn_evp_1d.F90 to more closely meet cice coding standard, changed stops to aborts, added subname, updated write/print statements, and updated spacing a little.
-- updated documentation, noted that kevp_kernel=2 is not validated
-- added an abort if kevp_kernel=2 is set. Also added an option so if kevp_kernel=102, the value of 2 is used. That allows testing. When kevp_kernel=2 is validated, this will have to be removed again.
Developer(s): tcraig
Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit
Does this PR create or have dependencies on Icepack or any other models? N
Is the documentation being updated with this PR? (Y/N) Y
Other Relevant Details:
test results are bit-for-bit, see #280d5caca949396 at https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks. I also ran a broad test suite with evp kernel=2 before and after and am comfortable the results were not changed for that option either.