Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Actions for macos system update #948

Merged
merged 6 commits into from
May 1, 2024

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented May 1, 2024

PR checklist

  • Short (1 sentence) summary of your PR:
    Fix latest problem with Github Actions for macos system update
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    TBD
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Github Actions broke again after default macos system update.

Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really, it's a zero-character modification? Thanks for dealing with this (over and over).

@apcraig
Copy link
Contributor Author

apcraig commented May 1, 2024

It's not fixed yet, need to trigger github actions to debug. First mod was adding a trivial change to create the PR, still trying to figure out what's happening. Unfortunately, I need to debug in the PR.

@eclare108213
Copy link
Contributor

I see. Would it not work to PR into another branch of your own?

@apcraig
Copy link
Contributor Author

apcraig commented May 1, 2024

True, I could test it in my fork first. That would require I explicitly turn on the github actions on that branch in my fork. Sort of easier just to do it in regular PR as long as others don't mind too much :)

@apcraig apcraig changed the title Fix Github Actions, Errrrr.... Fix Github Actions for macos system update May 1, 2024
@apcraig apcraig marked this pull request as ready for review May 1, 2024 19:55
@apcraig
Copy link
Contributor Author

apcraig commented May 1, 2024

This is ready for merge.

@apcraig apcraig merged commit 3e30553 into CICE-Consortium:main May 1, 2024
2 checks passed
@apcraig apcraig added the Porting label May 1, 2024
anton-seaice pushed a commit to ACCESS-NRI/CICE that referenced this pull request May 1, 2024
Github Actions broke again after default macos system update.

Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.
NickSzapiro-NOAA pushed a commit to NickSzapiro-NOAA/CICE that referenced this pull request May 2, 2024
Github Actions broke again after default macos system update.

Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants