Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgc code coverage #195

Closed
eclare108213 opened this issue Apr 17, 2018 · 4 comments
Closed

bgc code coverage #195

eclare108213 opened this issue Apr 17, 2018 · 4 comments
Assignees
Labels

Comments

@eclare108213
Copy link
Contributor

@njeffery Please let us know the proper namelist combinations to exercise these portions of the bgc code. The runs don't have to be science-worthy, we just need to be able to test the code to make sure changes are BFB, no segfaults, divzero, etc. Thanks!

What else needs to be on/off or otherwise set to run these:
skl_bgc = T
dEdd_algae = T
model_aero = T
solve_zsal = T

turn on DIC, Chl, Fe

It would be great to have a minimal, optimal-in-terms-of-coverage, yet somewhat realistic bgc test suite.

Also, get_forcing_bgc.F90 looks like it has a bug in it -- we're using the ISPOL and NICE datasets, but it doesn't look like the code to read them is exercised. ??? Maybe we don't have the namelist combos correct for these tests either.

@eclare108213
Copy link
Contributor Author

eclare108213 commented Jun 5, 2018

Skeletal layer tests (skl_bgc) were added in PR #199. Still to do:

  1. Limit time span of NICE tests to the dates when the forcing data is valid, and don't test restarts.
  2. Add skl tests to the standard suite.
  3. Check remaining code coverage items above.
  4. Add namelist fields for forcing filenames rather than having them hardwired in the code.

@eclare108213
Copy link
Contributor Author

PR #203 addresses items 1 and 2 above.

@eclare108213
Copy link
Contributor Author

PR #203 now also addresses item 4.

@eclare108213
Copy link
Contributor Author

eclare108213 commented Aug 7, 2018

The remaining item is code coverage, which is covered in #194

lettie-roach pushed a commit to lettie-roach/Icepack that referenced this issue Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants