-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgc code coverage #195
Labels
Comments
Skeletal layer tests (skl_bgc) were added in PR #199. Still to do:
|
PR #203 addresses items 1 and 2 above. |
PR #203 now also addresses item 4. |
The remaining item is code coverage, which is covered in #194 |
lettie-roach
pushed a commit
to lettie-roach/Icepack
that referenced
this issue
Oct 18, 2022
adding CMIP variable documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@njeffery Please let us know the proper namelist combinations to exercise these portions of the bgc code. The runs don't have to be science-worthy, we just need to be able to test the code to make sure changes are BFB, no segfaults, divzero, etc. Thanks!
What else needs to be on/off or otherwise set to run these:
skl_bgc = T
dEdd_algae = T
model_aero = T
solve_zsal = T
turn on DIC, Chl, Fe
It would be great to have a minimal, optimal-in-terms-of-coverage, yet somewhat realistic bgc test suite.
Also, get_forcing_bgc.F90 looks like it has a bug in it -- we're using the ISPOL and NICE datasets, but it doesn't look like the code to read them is exercised. ??? Maybe we don't have the namelist combos correct for these tests either.
The text was updated successfully, but these errors were encountered: