Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shortwave underflows and mechred divide by zero #127

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Feb 5, 2018

[Remove this and add a short summary line]: Refactor code to eliminate shortwave underflow and mechred divide by zero.
Developer(s): ehunke, tcraig
Are the code changes bit for bit, different at roundoff level, or more substantial? bfb in base_suite, but could be non-bfb in some cases
Is the documentation being updated with this PR? (Y/N) N
If not, does the documentation need to be updated separately? (Y/N) N
"Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://cice-consortium.github.io/Icepack/
Please suggest code reviewers in the column at right.
Other Relevant Details:

This fixes several debug abort on gnu

@apcraig apcraig self-assigned this Feb 5, 2018
@apcraig
Copy link
Contributor Author

apcraig commented Feb 5, 2018

This fixes 4 out of 6 failures on gnu with debug flags and addresses #48 and #118.

This also seems to be bit-for-bit in base suite testing. See 24755dd at https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I'm surprised that the shortwave changes are BFB, since those were creating underflows.

@eclare108213 eclare108213 merged commit ca4ea7d into CICE-Consortium:master Feb 6, 2018
This was referenced Feb 6, 2018
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants