Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quotes to fix icepack.script problem on Mac OS X v1.0.0.d0003 #175

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Added quotes to fix icepack.script problem on Mac OS X v1.0.0.d0003 #175

merged 1 commit into from
Feb 14, 2018

Conversation

proteanplanet
Copy link
Contributor

@proteanplanet proteanplanet commented Feb 13, 2018

This small tweak fixes issue #174: "Bug in icepack.setup" :
When running on Mac OSX, the operating system allows spaces to occur in paths:
e.g. "/Volumes/Promise RAID/work/Icepack"
However, if icepack.setup is run from such a location, it crashes, because the lines:
set ICE_SANDBOX = pwd
set ICE_SCRIPTS = ${ICE_SANDBOX}/configuration/scripts
Do not allow for this occurrence. Placing quotes or parentheses around the second line fixes the problem:
set ICE_SCRIPTS = "${ICE_SANDBOX}/configuration/scripts"

Are the code changes bit for bit, different at roundoff level, or more substantial? BIT-FOR-BIT
Is the documentation being updated with this PR? NO
If not, does the documentation need to be updated separately? NO
Please suggest code reviewers in the column at right: TONY
~

@eclare108213
Copy link
Contributor

Thanks Andrew. We're already too far along with the current release to add this in, but we'll test and merge it soon, consistent with our plans to have the latest-and-greatest versions available all the time. Just FYI.

@proteanplanet
Copy link
Contributor Author

proteanplanet commented Feb 13, 2018 via email

Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down!

@apcraig apcraig changed the title Added quotes to fix icepack.script problem on Mac OS X v1.0.0.d0003 Added quotes to fix icepack.script problem on Mac OS X Feb 14, 2018
@apcraig apcraig changed the title v1.0.0.d0003 Added quotes to fix icepack.script problem on Mac OS X Added quotes to fix icepack.script problem on Mac OS X v1.0.0.d0003 Feb 14, 2018
@apcraig apcraig merged commit 5a20290 into CICE-Consortium:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants