Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readthedocs #187

Merged
merged 8 commits into from
Mar 28, 2018
Merged

Readthedocs #187

merged 8 commits into from
Mar 28, 2018

Conversation

duvivier
Copy link
Contributor

Updating documentation to include readthedocs.org stuff

Developer(s): Alice DuVivier
Are the code changes bit for bit, different at roundoff level, or more substantial? bit for bit
Is the documentation being updated with this PR? (Y/N) Yes
If not, does the documentation need to be updated separately? (Y/N) No
"Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://cice-consortium.github.io/Icepack/
Please suggest code reviewers in the column at right.
Other Relevant Details:

  • You can see the updated documentation at my readthedocs.org personal site: https://readthedocs.org/projects/icepack/
    -Added Collins reference from Issue BGC forcing #73
    -Added documentation to HTML for how to use readthedocs.org for issue update wikis for readthedocs #185
    -Removed extraneous documents from /docs/ directory from issue Clean up Icepack /doc/ file #186
  • I updated README.md to reflect the new documentation location. I've double checked and the wiki links are correct.
    -I also updated the PR template since it referenced the old documentation site. I also tried to better highlight the sections people need to answer since the big block of text can run together a bit.

@duvivier
Copy link
Contributor Author

@apcraig @eclare108213 I think if this all looks good we can soon delete the gh-pages branch. I want you both to look through this all carefully before we do that though. But I'd suggest perhaps waiting for v1.0.1 release until after gh-pages has been deleted.

@duvivier
Copy link
Contributor Author

It might also be nice to add the green "docs passing" badge (see here: https://github.com/rtfd/readthedocs.org under README.rst) to the PR process. Thoughts on how to do this?

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under dg_documentation.rst, does it matter if the readthedocs username is different from the one on github? It might help to indicate that USERNAME with capital letters means the user needs to replace it with their actual username.

We aren't using the git workflow guide on google docs anymore -- that was moved to the wiki, so the links here need to be changed.

@duvivier
Copy link
Contributor Author

No, you can choose any username you want. I think it's easiest to have them match, but ultimately that would be up to the user. I've clarified this as well as the USERNAME placeholder in the docs. I also modified the link to the workflow guide to point to the CICE wiki.

@eclare108213
Copy link
Contributor

sorry to be so nit-picky, but there's still at least one reference to the google doc, line 164 of dg_documentation...

@duvivier
Copy link
Contributor Author

It's not nitpicky, it is good to be consistent and I'd missed that one.

@eclare108213
Copy link
Contributor

Thanks Alice. I'll merge this one, and we can fix other things as we find them. There's always more to do....

@eclare108213 eclare108213 merged commit 6239bad into CICE-Consortium:master Mar 28, 2018
@duvivier duvivier deleted the readthedocs branch March 28, 2018 19:24
This was referenced Mar 28, 2018
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
update pgi compiler optimization to address reproducibility problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants