Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating PR template, doc links to PR info #260

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Updating PR template, doc links to PR info #260

merged 2 commits into from
Jun 18, 2019

Conversation

duvivier
Copy link
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Clean up the PR template process and links to PR info in documentation.
  • Developer(s):
    Alice DuVivier
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    N/A, will only need Travis CI test
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    Parallel to CICE PR Add lcov capability #324 to make PR template more streamlined.

Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I just noticed is the the tick boxes add some content to the PR. It shows "9 out of 16" on the Pull Request list. That seems to mean 9 out of 16 tick boxes are checked. I guess github things tick boxes are used for a list, not to pick one of several options. Anyway, I don't think it's a big deal at this point, just wanted to point it out.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@duvivier
Copy link
Contributor Author

@apcraig I'm not sure how to get rid of the task numbering without entirely removing the checkboxes. But maybe we just shouldn't worry for now? We can see how this works for us for a bit and make changes as needed.

@duvivier duvivier merged commit a31e755 into CICE-Consortium:master Jun 18, 2019
@duvivier duvivier deleted the doc branch June 18, 2019 02:31
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants