Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING, update README #293

Merged
merged 2 commits into from
Feb 2, 2020
Merged

Add CONTRIBUTING, update README #293

merged 2 commits into from
Feb 2, 2020

Conversation

phil-blain
Copy link
Member

PR checklist

  • Short (1 sentence) summary of your PR:
    Add CONTRIBUTING.md and update README to follow Add CONTRIBUTING, update README CICE#392
  • Developer(s):
    Philippe Blain
  • Suggest PR reviewers from list in the column to the right.
    @eclare108213 @duvivier @apcraig
  • Please copy the PR test results link or provide a summary of testing completed below.
    No tests.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Same change as in CICE-Consortium/CICE#392.

@phil-blain
Add CONTRIBUTING.md
f739754
@phil-blain
README: update to mirror CICE
9e5566b 
- Link to the Contributing huide in the About-Us wiki
- Add 'Getting Help' section
- Change the top-level title
- Fix capitalization
@phil-blain phil-blain mentioned this pull request Jan 31, 2020
Merged
16 tasks
@duvivier
Copy link
Contributor

@phil-blain I just gave more thorough comments to the CICE PR. The same comments apply here, so rather than make them again reference those.

Thanks for doing this!

eclare108213
eclare108213 approved these changes Feb 2, 2020
View reviewed changes
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge and make similar changes to these files as in the related CICE PR.

@eclare108213 eclare108213 merged commit c60588e into CICE-Consortium:master Feb 2, 2020
@phil-blain phil-blain deleted the add-contributing branch February 13, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-blain @duvivier @eclare108213